Adds --version support#206
Merged
sylvestre merged 2 commits intouutils:mainfrom Dec 14, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 13 13
Lines 5485 5486 +1
Branches 301 301
=======================================
+ Hits 4419 4420 +1
Misses 1064 1064
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
could you please add a test to make sure we don't regress in the future? thanks |
Contributor
Author
|
Done! I've added the test case in the latest commit. |
sylvestre
reviewed
Dec 13, 2025
| #[test] | ||
| fn test_version() { | ||
| let short = new_ucmd!() | ||
| .arg("-V") |
Contributor
There was a problem hiding this comment.
-V isn't supported upstream
Contributor
There was a problem hiding this comment.
@sylvestre wouldn't it make sense to keep it as an extension? Similar to the coreutils?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #166
Adds missing
--version/-Vflag support tosed.First PR to this org, feedback welcome!