Skip to content

Adds --version support #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sylvestre merged 2 commits into from
Dec 14, 2025
Merged

Adds --version support #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b774886
add version support
pocopepe Dec 13, 2025
e64fc4b
adds testing
pocopepe Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sed/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use crate::sed::command::{ProcessingContext, StringSpace};
use crate::sed::compiler::compile;
use crate::sed::processor::process_all_files;
use crate::sed::script_line_provider::ScriptValue;
use clap::{Arg, ArgMatches, Command, arg};
use clap::{Arg, ArgMatches, Command, arg, crate_version};
use std::collections::HashMap;
use std::path::PathBuf;
use uucore::error::{UResult, UUsageError};
Expand All @@ -47,6 +47,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
#[allow(clippy::cognitive_complexity)]
pub fn uu_app() -> Command {
Command::new(uucore::util_name())
.version(crate_version!())
.about(ABOUT)
.override_usage(format_usage(USAGE))
.infer_long_args(true)
Expand Down
16 changes: 16 additions & 0 deletions tests/by-util/test_sed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@ fn test_invalid_arg() {
new_ucmd!().arg("--definitely-invalid").fails().code_is(1);
}

#[test]
fn test_version() {
let short = new_ucmd!()
.arg("-V")
Copy link
Copy Markdown
Contributor

@sylvestre sylvestre Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-V isn't supported upstream

Copy link
Copy Markdown
Contributor

@cakebaker cakebaker Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sylvestre wouldn't it make sense to keep it as an extension? Similar to the coreutils?

Copy link
Copy Markdown
Contributor

@sylvestre sylvestre Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

.succeeds()
.no_stderr()
.stdout_str()
.to_owned();

new_ucmd!()
.arg("--version")
.succeeds()
.no_stderr()
.stdout_is(short);
}

#[test]
fn test_debug() {
new_ucmd!().args(&["--debug", ""]).succeeds();
Expand Down
Loading