Skip to content

Conversation

@pront
Copy link
Member

@pront pront commented Aug 7, 2025

Summary

This is very similar to the native codecs.

Vector configuration

How did you test this PR?

I manually tested this while working on #23524

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested a review from a team as a code owner August 7, 2025 15:06
@pront pront enabled auto-merge August 7, 2025 15:08
@pront pront added this pull request to the merge queue Aug 7, 2025
Merged via the queue into master with commit f9d2800 Aug 7, 2025
99 of 100 checks passed
@pront pront deleted the pront-protobuf-codecs branch August 7, 2025 16:06
pront added a commit that referenced this pull request Aug 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Aug 18, 2025
* Revert "chore(codecs protobuf): allow all telemetry types (#23550)"

This reverts commit f9d2800.

* add known issue

* encoder supports traces too

* Update website/cue/reference/releases/0.49.0.cue

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

---------

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
pront added a commit that referenced this pull request Aug 26, 2025
* Revert "chore(codecs protobuf): allow all telemetry types (#23550)"

This reverts commit f9d2800.

* add known issue

* encoder supports traces too

* Update website/cue/reference/releases/0.49.0.cue

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>

---------

Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants