-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(opentelemetry sink): introduce otlp encoder
#23850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-e2e-opentelemetry-logs
use_otlp_encoding optionotlp encoder
|
@pront thank you for doing all this work related to improving open telemetry source/sink in Vector. I tried out I also compiled this version and now it just works. Any suggestions on why I can't achieve direct output from source to sink in 0.50.0? |
thomasqueirozb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e test and docs look really nice now!
Hello, @ozanichkovsky, can you create a discussion and provide your config, sample input data, and what changes you made before re-compiling?
Good to hear, you can use the nightly version after this PR is merged. |
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-component-features
I want to follow up and add metrics and traces to the E2E. Should be a matter of using an enhanced generator, maybe I will take another look at this PR, try locally to also push through metrics and traces and then I will enqueue. If you have more comments by then, just leave them as review comments. |
pront
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-component-features
Summary
The main purpose of this feature is to simplify OTEL sink configuration from:
to
I had to implement default for
EncodingConfigWithFramingotherwise users would have to set a codec that would always be ignored. Hence the numerous CUE changes.Vector configuration
How did you test this PR?
E2E tests were adapted.
I will also follow up in another PR to improve the E2E so we can test:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Related:
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.