Use ncc to bundle webpack by dav-is · Pull Request #6347 · vercel/next.js

dav-is · 2019-02-19T03:32:47Z

This will bundle webpack with next using ncc

wtgtybhertgeghgtwtg · 2019-02-19T16:15:38Z

Please forgive me for my ignorance in the matter, but I couldn't find any relevant Issues. Outside of avoiding errors when the user has another version of webpack installed, are there benefits to this approach? It'll likely increase install size (since webpack's dependencies can't dedupe) and give warnings on install (since the peer dependency webpack is no longer around), as well as obscure any security advisories webpack or its dependencies would receive.

timneutkens · 2019-02-19T16:27:50Z

@wtgtybhertgeghgtwtg we'll be nccing most of Next.js meaning that the dependencies would be deduped at build time. ncc itself bundles webpack too and it works perfectly, install size is smaller and it's way less error prone, eg the acorn install issue etc are a thing of the past.

For now we're starting with webpack because it's the easiest way to start off this bundling work.

wtgtybhertgeghgtwtg · 2019-02-19T16:46:48Z

Sorry if I wasn't clear, I meant for a project using next, not next itself. next will get smaller and its dependency tree will be deduped, but they won't be able to be deduped with the versions used by other packages. So people using jest alongside with next may see an increase in install size, since it can't share versions of glob and micromatch with next.

Depending on what you end up bundling, this might occur in next, as well (if you bundle webpackbar or launch-editor, but not the dependencies for the babel config, chalk won't be able to dedupe), but that probably still be a net decrease of package size.

rauchg · 2019-02-19T18:17:19Z

@wtgtybhertgeghgtwtg Next.js will get security warnings from GitHub's analysis of package.json, so we are not concerned from that standpoint

There's a major security benefit from compiling into a standalone bundle (the same way that yarn does), which is that no nested "unpinned" dependencies that the Next.js team doesn't know about get installed.

So, we forego npm audit in favor of not shipping the vulnerabilities to begin with.

wtgtybhertgeghgtwtg · 2019-02-19T18:45:02Z

Next.js will get security warnings from GitHub's analysis of package.json, so we are not concerned from that standpoint

That works for next, but not necessarily users of next. Even if you release a new version to include a patch for a bundled dependency, unless the unpatched version of next is marked as insecure, they have no reasonable way of knowing that they potentially have a security vulnerability.

in favor of not shipping the vulnerabilities to begin with.

It'll avoid shipping versions that have a known vulnerability, but that doesn't mean that vulnerabilities cannot be discovered for the existing version it is using.

github-actions · 2019-04-26T15:48:19Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	12.2s	12.2s	-42ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	637 kB	637 kB	⚠️ +92 B

Click to expand serverless stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	14.8s	14.9s	⚠️ +26ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Serverless `pages/link` Size	327 kB	327 kB	-5 B
Serverless `pages/link` gzip Size	87.5 kB	87.5 kB	⚠️ +2 B
Serverless `pages/index` Size	321 kB	321 kB	-5 B
Serverless `pages/index` gzip Size	85.6 kB	85.6 kB	⚠️ +2 B
Serverless `pages/_error` Size	322 kB	322 kB	-5 B
Serverless `pages/_error` gzip Size	85.3 kB	85.3 kB	✓
Serverless `pages/routerDirect` Size	321 kB	321 kB	-5 B
Serverless `pages/routerDirect` gzip Size	85.6 kB	85.6 kB	⚠️ +2 B
Serverless `pages/withRouter` Size	321 kB	321 kB	-5 B
Serverless `pages/withRouter` gzip Size	85.7 kB	85.7 kB	⚠️ +2 B
Build Dir Size	2.19 MB	2.19 MB	⚠️ +71 B

github-actions · 2019-04-26T16:10:28Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	11.7s	11.5s	-187ms
`node_modules` Size	39.6 MB	36 MB	-3.54 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	637 kB	637 kB	⚠️ +92 B

Click to expand serverless stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	14s	14.5s	⚠️ +507ms
`node_modules` Size	39.6 MB	36 MB	-3.54 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Serverless `pages/link` Size	327 kB	327 kB	-5 B
Serverless `pages/link` gzip Size	87.5 kB	87.5 kB	✓
Serverless `pages/index` Size	321 kB	321 kB	-5 B
Serverless `pages/index` gzip Size	85.6 kB	85.6 kB	⚠️ +1 B
Serverless `pages/_error` Size	322 kB	322 kB	-5 B
Serverless `pages/_error` gzip Size	85.3 kB	85.3 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	321 kB	321 kB	-5 B
Serverless `pages/routerDirect` gzip Size	85.6 kB	85.6 kB	⚠️ +2 B
Serverless `pages/withRouter` Size	321 kB	321 kB	-5 B
Serverless `pages/withRouter` gzip Size	85.7 kB	85.7 kB	⚠️ +2 B
Build Dir Size	2.19 MB	2.19 MB	⚠️ +71 B

SingleEntryPlugin for dev addEntry

github-actions · 2019-04-26T18:17:06Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	13.1s	11.9s	-1.2s
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +29 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +2 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	637 kB	637 kB	⚠️ +92 B

Click to expand serverless stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	14.3s	14.4s	⚠️ +120ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Serverless `pages/link` Size	327 kB	327 kB	-5 B
Serverless `pages/link` gzip Size	87.5 kB	87.5 kB	✓
Serverless `pages/index` Size	321 kB	321 kB	-5 B
Serverless `pages/index` gzip Size	85.6 kB	85.6 kB	⚠️ +1 B
Serverless `pages/_error` Size	322 kB	322 kB	-5 B
Serverless `pages/_error` gzip Size	85.3 kB	85.3 kB	⚠️ +2 B
Serverless `pages/routerDirect` Size	321 kB	321 kB	-5 B
Serverless `pages/routerDirect` gzip Size	85.6 kB	85.6 kB	✓
Serverless `pages/withRouter` Size	321 kB	321 kB	-5 B
Serverless `pages/withRouter` gzip Size	85.7 kB	85.7 kB	✓
Build Dir Size	2.19 MB	2.19 MB	⚠️ +71 B

github-actions · 2019-04-26T18:22:22Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	13s	12.5s	-454ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	637 kB	637 kB	⚠️ +92 B

Click to expand serverless stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	14.7s	14.6s	-94ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +27 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	✓
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Serverless `pages/link` Size	327 kB	327 kB	-5 B
Serverless `pages/link` gzip Size	87.5 kB	87.5 kB	-1 B
Serverless `pages/index` Size	321 kB	321 kB	-5 B
Serverless `pages/index` gzip Size	85.6 kB	85.6 kB	⚠️ +2 B
Serverless `pages/_error` Size	322 kB	322 kB	-5 B
Serverless `pages/_error` gzip Size	85.3 kB	85.3 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	321 kB	321 kB	-5 B
Serverless `pages/routerDirect` gzip Size	85.6 kB	85.6 kB	⚠️ +1 B
Serverless `pages/withRouter` Size	321 kB	321 kB	-5 B
Serverless `pages/withRouter` gzip Size	85.7 kB	85.7 kB	✓
Build Dir Size	2.19 MB	2.19 MB	⚠️ +71 B

github-actions · 2019-04-26T19:46:19Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	11.6s	11.3s	-364ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +28 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	⚠️ +1 B
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	637 kB	637 kB	⚠️ +92 B

Click to expand serverless stats

	zeit/next.js canary	zeit/next.js next-ncc	Change
Build Duration	13.4s	13s	-399ms
`node_modules` Size	39.6 MB	35.8 MB	-3.81 MB
Total Bundle (main, webpack, commons) Size	207 kB	207 kB	⚠️ +50 B
Total Bundle (main, webpack, commons) gzip Size	68.2 kB	68.2 kB	⚠️ +27 B
Client `_app` Size	2.13 kB	2.13 kB	✓
Client `_app` gzip Size	919 B	919 B	✓
Client `_error` Size	14.2 kB	14.2 kB	✓
Client `_error` gzip Size	5.39 kB	5.39 kB	✓
Client `pages/index` Size	288 B	288 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	3.62 kB	3.62 kB	✓
Client `pages/link` gzip Size	1.63 kB	1.63 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.9 kB	27.9 kB	-15 B
Client `main` gzip Size	9.64 kB	9.64 kB	✓
Client `commons` Size	177 kB	177 kB	⚠️ +65 B
Client `commons` gzip Size	57.4 kB	57.4 kB	⚠️ +27 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	769 B	769 B	✓
Serverless `pages/link` Size	327 kB	327 kB	-5 B
Serverless `pages/link` gzip Size	87.5 kB	87.5 kB	⚠️ +1 B
Serverless `pages/index` Size	321 kB	321 kB	-5 B
Serverless `pages/index` gzip Size	85.6 kB	85.6 kB	⚠️ +1 B
Serverless `pages/_error` Size	322 kB	322 kB	-5 B
Serverless `pages/_error` gzip Size	85.3 kB	85.3 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	321 kB	321 kB	-5 B
Serverless `pages/routerDirect` gzip Size	85.6 kB	85.6 kB	✓
Serverless `pages/withRouter` Size	321 kB	321 kB	-5 B
Serverless `pages/withRouter` gzip Size	85.7 kB	85.7 kB	⚠️ +2 B
Build Dir Size	2.19 MB	2.19 MB	⚠️ +71 B

dav-is added 7 commits February 18, 2019 17:58

First implementation

b6f62e7

Use taskr for ncc

e96676d

Use .ts module alias, use next/webpack for .js

897166b

Temp remove yarn check

a4d1119

Remove taskfile webpack -> next/webpack

071b85e

add webpack resolve to compiled webpack

607d923

Cleanup

239200e

timneutkens reviewed Feb 19, 2019

View reviewed changes

Comment thread packages/next/build/webpack-config.js Outdated

timneutkens mentioned this pull request Feb 19, 2019

Build failing with spawn ENOMEM / spawn E2BIG #6353

Closed

Use module-alias

269185c

dav-is marked this pull request as ready for review February 19, 2019 22:33

dav-is added 4 commits February 19, 2019 16:35

Merge branch 'canary' into next-ncc

6f26674

Merge branch 'canary' into next-ncc

57ad184

Merge branch 'canary' into next-ncc

1f0cf33

Remove webpack before tests

b7f04c3

timneutkens reviewed Feb 21, 2019

View reviewed changes

Comment thread packages/next/build/index.ts Outdated

dav-is added 4 commits February 21, 2019 16:14

Use advanced module aliasing

6c4e3d4

Merge branch 'canary' into next-ncc

891027f

Add entire /webpack/lib

c3399ae

Merge branch 'canary' into next-ncc

67c0d0a

Janpot mentioned this pull request Feb 27, 2019

Dependency version restrictions #6465

Closed

dav-is added 4 commits March 28, 2019 07:15

Merge branch 'canary' into next-ncc

01a6916

Fix dirty merge resolution

85d6267

ncc webpack and plugins that require webpack

a5ba811

Remove unneeded path option

edfa3b9

dav-is and others added 14 commits March 28, 2019 12:38

Merge branch 'next-ncc' of github.com:zeit/next.js into next-ncc

634bfba

Update react-loadable-plugin.ts

e32c4e2

Update webpack.d.ts

922149f

Merge branch 'canary' into next-ncc

ab13125

Fix Typescript

8e357f4

Remove from production deps

82121a0

Update React types

aacbac6

@types/react

99eadc2

Merge branch 'canary' into next-ncc

1f8f140

Fix url module resolving in ncced webpack

2c1a184

Merge branch 'canary' into next-ncc

8392c62

Mock more process props and only mock global in client build

5a8993f

Merge branch 'canary' into next-ncc

d883a52

Add node-libs-browser dependency

805324d

ncc DynamicEntryPlugin and log errors in dev

30438f2

ijjk added 2 commits April 26, 2019 13:11

Remove DynamicEntryPlugin and only use

7907235

SingleEntryPlugin for dev addEntry

Merge branch 'canary' into next-ncc

9c33cea

Merge branch 'canary' into next-ncc

7849ee1

ijjk approved these changes Apr 26, 2019

View reviewed changes

dav-is requested a review from timneutkens April 26, 2019 19:58

dav-is merged commit f66546f into canary Apr 26, 2019

dav-is deleted the next-ncc branch April 26, 2019 22:24

guybedford mentioned this pull request May 10, 2019

ncc Webpack build #7301

Merged

guybedford mentioned this pull request Jun 21, 2019

ncc Webpack build redux #7628

Merged

lock Bot locked as resolved and limited conversation to collaborators Apr 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ncc to bundle webpack#6347

Use ncc to bundle webpack#6347
dav-is merged 40 commits into
canaryfrom
next-ncc

dav-is commented Feb 19, 2019 •

edited

Loading

Uh oh!

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

timneutkens commented Feb 19, 2019

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

rauchg commented Feb 19, 2019

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2019

Uh oh!

github-actions Bot commented Apr 26, 2019

Uh oh!

github-actions Bot commented Apr 26, 2019

Uh oh!

github-actions Bot commented Apr 26, 2019

Uh oh!

github-actions Bot commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

dav-is commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

timneutkens commented Feb 19, 2019

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

rauchg commented Feb 19, 2019

Uh oh!

wtgtybhertgeghgtwtg commented Feb 19, 2019

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Apr 26, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Apr 26, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Apr 26, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Apr 26, 2019

Stats from current PR

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dav-is commented Feb 19, 2019 •

edited

Loading