ncc Webpack build redux by guybedford · Pull Request #7628 · vercel/next.js

guybedford · 2019-06-21T11:38:18Z

This reinstates the ncc webpack build (previously #7301, #6347), specifically fixing the issue in #7369.

Careful handling of remapping of externals is provided through the new exports object support in ncc, allowing better shared code.

See for example the webpack bundle technique in bundled-webpack.js and how that avoids duplication of webpack between usage. The autoDll override approach was also updated similarly to be fully ncc compatible.

Since fully automated multi-entry builds are not possible currently due to the various Webpack issues, these same techniques applied progressively to build all dependencies while retaining shared dependency links will be the best approach for next.js.

This reverts commit 6feca31.

github-actions · 2019-06-21T11:48:22Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	12.2s	11.7s	-470ms
`node_modules` Size	41.3 MB	39.2 MB	-2.09 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	13.1s	12.8s	-291ms
`node_modules` Size	41.3 MB	39.2 MB	-2.09 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	✓
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	-1 B
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	✓
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	-2 B
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	✓
Build Dir Size	2.3 MB	2.3 MB	✓

github-actions · 2019-06-21T12:19:42Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	12.4s	11.7s	-752ms
`node_modules` Size	41.3 MB	39.2 MB	-2.06 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-4 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	-1 B
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	-1 B
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	224 B	⚠️ +2 B
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	-1 B
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	12.9s	12.8s	-138ms
`node_modules` Size	41.3 MB	39.2 MB	-2.06 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	✓
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	✓
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	-1 B
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	-1 B
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	✓
Build Dir Size	2.3 MB	2.3 MB	✓

guybedford · 2019-06-21T13:27:05Z

Just tracking down here why webpack-dev-middleware is not calling the ready callback at all resulting in timeouts.

github-actions · 2019-06-21T14:20:23Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	12.3s	12s	-348ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	13.4s	12.9s	-548ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-4 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	-1 B
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	-1 B
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	224 B	⚠️ +2 B
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	-1 B
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	⚠️ +1 B
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	⚠️ +1 B
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	⚠️ +1 B
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	⚠️ +2 B
Build Dir Size	2.3 MB	2.3 MB	✓

github-actions · 2019-06-21T15:17:56Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	13.8s	13.1s	-756ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	15s	14.4s	-555ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-6 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	⚠️ +1 B
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	⚠️ +1 B
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	224 B	222 B	-2 B
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	⚠️ +1 B
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	⚠️ +1 B
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	⚠️ +1 B
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	⚠️ +1 B
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	⚠️ +1 B
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	⚠️ +2 B
Build Dir Size	2.3 MB	2.3 MB	✓

github-actions · 2019-06-21T15:27:47Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	12.8s	12s	-777ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	13.5s	13.1s	-429ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	-1 B
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	-1 B
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	-1 B
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	-1 B
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	-1 B
Build Dir Size	2.3 MB	2.3 MB	✓

github-actions · 2019-06-21T15:49:16Z

Stats from current PR

Click to expand stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	13.9s	13.1s	-815ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Base Rendered Size	1.34 kB	1.34 kB	✓
Build Dir Size	804 kB	804 kB	✓

Click to expand serverless stats

	zeit/next.js canary	guybedford/next.js canary-ncc	Change
Build Duration	14.9s	14.6s	-235ms
`node_modules` Size	41.3 MB	39.2 MB	-2.07 MB
Total Bundle (main, webpack, commons) Size	213 kB	213 kB	✓
Total Bundle (main, webpack, commons) gzip Size	70 kB	70 kB	-5 B
Client `_app` Size	2.39 kB	2.39 kB	✓
Client `_app` gzip Size	1.08 kB	1.08 kB	✓
Client `_error` Size	8.78 kB	8.78 kB	✓
Client `_error` gzip Size	3.31 kB	3.31 kB	✓
Client `pages/index` Size	296 B	296 B	✓
Client `pages/index` gzip Size	222 B	222 B	✓
Client `pages/link` Size	4.79 kB	4.79 kB	✓
Client `pages/link` gzip Size	2.05 kB	2.05 kB	✓
Client `pages/routerDirect` Size	411 B	411 B	✓
Client `pages/routerDirect` gzip Size	296 B	296 B	✓
Client `pages/withRouter` Size	393 B	393 B	✓
Client `pages/withRouter` gzip Size	280 B	280 B	✓
Client `main` Size	27.6 kB	27.6 kB	✓
Client `main` gzip Size	9.13 kB	9.13 kB	✓
Client `commons` Size	183 kB	183 kB	✓
Client `commons` gzip Size	59.6 kB	59.6 kB	-5 B
Client `webpack` Size	1.49 kB	1.49 kB	✓
Client `webpack` gzip Size	770 B	770 B	✓
Serverless `pages/link` Size	339 kB	339 kB	✓
Serverless `pages/link` gzip Size	87.1 kB	87.1 kB	-1 B
Serverless `pages/index` Size	330 kB	330 kB	✓
Serverless `pages/index` gzip Size	84.7 kB	84.7 kB	✓
Serverless `pages/_error` Size	330 kB	330 kB	✓
Serverless `pages/_error` gzip Size	84.4 kB	84.4 kB	✓
Serverless `pages/routerDirect` Size	331 kB	331 kB	✓
Serverless `pages/routerDirect` gzip Size	84.7 kB	84.7 kB	✓
Serverless `pages/withRouter` Size	331 kB	331 kB	✓
Serverless `pages/withRouter` gzip Size	84.6 kB	84.6 kB	-1 B
Build Dir Size	2.3 MB	2.3 MB	✓

This reverts commit e85a517.

guybedford added 2 commits June 21, 2019 12:55

Reimplement ncc webpack build

24c45eb

This reverts commit 6feca31.

Shared webpack build

70a81d6

guybedford requested review from Timer, dav-is, ijjk, lfades and timneutkens as code owners June 21, 2019 11:38

ncc workaround pending @zeit/nccvercel#437

d4f0e74

update ncc

2df016f

build tweaks, fixup autodll-import

65bf615

possible Node 8 fix

6c2818e

second possible Node 8 fix

7da5d64

and update taskfile

99ed8b9

Timer reviewed Jun 21, 2019

View reviewed changes

Comment thread packages/next/package.json

Timer approved these changes Jun 21, 2019

View reviewed changes

Timer merged commit e85a517 into vercel:canary Jun 21, 2019

nblthree mentioned this pull request Jun 23, 2019

Latest 8.1.1-canary.55 version compatibility issue with next-css plugin #7632

Closed

Timer added a commit to Timer/next.js that referenced this pull request Jun 24, 2019

Revert "ncc Webpack build redux (vercel#7628)"

31b3106

This reverts commit e85a517.

lock Bot locked as resolved and limited conversation to collaborators Jun 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ncc Webpack build redux#7628

ncc Webpack build redux#7628
Timer merged 8 commits into
vercel:canaryfrom
guybedford:canary-ncc

guybedford commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

guybedford commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

guybedford commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

guybedford commented Jun 21, 2019

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

github-actions Bot commented Jun 21, 2019

Stats from current PR

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants