Skip to content

Turbopack: refactor ESM codegen generation#92777

Merged
mischnic merged 2 commits into
canaryfrom
mischnic/refactor-esm-codegen
Apr 15, 2026
Merged

Turbopack: refactor ESM codegen generation#92777
mischnic merged 2 commits into
canaryfrom
mischnic/refactor-esm-codegen

Conversation

@mischnic
Copy link
Copy Markdown
Member

@mischnic mischnic commented Apr 14, 2026

Move more logic out of the ModuleReferencesVisitor, so that we can remove it at some point.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Apr 14, 2026
Copy link
Copy Markdown
Member Author

mischnic commented Apr 14, 2026

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 14, 2026

Merging this PR will improve performance by 4.4%

⚡ 1 improved benchmark
✅ 7 untouched benchmarks
⏩ 12 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation packages-bundle.js[full] 1,025.4 ms 982.2 ms +4.4%

Comparing mischnic/refactor-esm-codegen (41c3115) with canary (ab4ec43)2

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on canary (7f3cfff) during the generation of this report, so ab4ec43 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@nextjs-bot
Copy link
Copy Markdown
Contributor

nextjs-bot commented Apr 14, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ██▁▁▁
Cold (Ready in log) 453ms 456ms ▁▁▁▂▂
Cold (First Request) 879ms 882ms ▁▇▁▁▁
Warm (Listen) 455ms 456ms ▅▅▅▅▅
Warm (Ready in log) 455ms 455ms ▁▃▁▂▂
Warm (First Request) 368ms 362ms ▁▂▁▂▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ▅█▅▁▅
Cold (Ready in log) 438ms 439ms ▆▅█▆▂
Cold (First Request) 1.930s 1.925s ▅▆██▂
Warm (Listen) 456ms 456ms ▅▁█▅▅
Warm (Ready in log) 436ms 438ms ▅▄█▄▂
Warm (First Request) 1.929s 1.941s ▅▆█▅▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.212s 4.224s ▄▁▁▃▃
Cached Build 4.273s 4.289s ▃▁▂▃▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.467s 14.378s ▃▄█▃▆
Cached Build 14.591s 14.544s ▂▁█▂▁
node_modules Size 493 MB 493 MB ▇▇▇▇▇
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
053b9v5j96uu_.js gzip 8.56 kB N/A -
07p3thve3usj7.js gzip 166 B N/A -
07rxhp_1_g4mu.js gzip 13.1 kB N/A -
096aa2uod0_wa.js gzip 9.82 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0ea8vo2o6kp_s.js gzip 13.3 kB N/A -
0egovw6-5i1e3.js gzip 8.57 kB N/A -
0fli3_wppnim5.js gzip 12.9 kB N/A -
0k09jwjeb-tki.js gzip 13.8 kB N/A -
0kb7_ep3r1z0_.js gzip 10.1 kB N/A -
0kmgih16pb2zy.js gzip 9.24 kB N/A -
0wxpyd8r-vipl.js gzip 1.47 kB N/A -
0y65wbx0qseem.js gzip 152 B N/A -
1-z_xm7pzpbeh.js gzip 49.2 kB N/A -
10ya12vguoq-y.js gzip 158 B N/A -
16lhqjoqbznyg.js gzip 220 B 220 B
16vepdkipri3r.js gzip 8.51 kB N/A -
17n96uu6y1pxq.js gzip 8.6 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1hf51c3eumcxi.js gzip 154 B N/A -
1ke9exnwf9qrv.js gzip 154 B N/A -
1xvs50ql8hjy-.js gzip 155 B N/A -
1xz7fhgdco-x_.js gzip 8.59 kB N/A -
2__-e_ym8n788.js gzip 450 B N/A -
22o6xd9_ywdu6.js gzip 233 B N/A -
22wiu3_w41px6.js gzip 154 B N/A -
27acvxqigrsj2.js gzip 156 B N/A -
2copo157fzx7p.js gzip 155 B N/A -
2k1q_gre6hp0-.js gzip 8.56 kB N/A -
2kvj8yrfznmwx.js gzip 5.69 kB N/A -
2sgqisp4604si.js gzip 8.51 kB N/A -
342ijzvrpe53h.js gzip 2.29 kB N/A -
37rwzi4-whe5o.js gzip 155 B N/A -
3aae8vl16eepq.js gzip 159 B N/A -
3d3clma6-4r23.js gzip 65.5 kB N/A -
3nv9kgq774d9_.js gzip 154 B N/A -
3on3bb1ndhdz5.js gzip 70.8 kB N/A -
3v9s-fz24f8oo.js gzip 10.4 kB N/A -
3z6plg323x4y-.js gzip 155 B N/A -
420pn_b9x-3ir.js gzip 8.62 kB N/A -
44un3--wmqiyh.js gzip 7.61 kB N/A -
turbopack-0r..2k03.js gzip 4.19 kB N/A -
turbopack-1-..1ran.js gzip 4.2 kB N/A -
turbopack-11..vj4e.js gzip 4.19 kB N/A -
turbopack-1a..h9x-.js gzip 4.19 kB N/A -
turbopack-1i.._4ap.js gzip 4.19 kB N/A -
turbopack-1j..n9t-.js gzip 4.19 kB N/A -
turbopack-1l..rpeq.js gzip 4.19 kB N/A -
turbopack-1v.._r7v.js gzip 4.19 kB N/A -
turbopack-23..bd9g.js gzip 4.17 kB N/A -
turbopack-2i..h9xj.js gzip 4.19 kB N/A -
turbopack-37..oumk.js gzip 4.19 kB N/A -
turbopack-38..olal.js gzip 4.19 kB N/A -
turbopack-3o.._3ij.js gzip 4.19 kB N/A -
turbopack-3t..kvh8.js gzip 4.19 kB N/A -
03_szppy5nakp.js gzip N/A 49.2 kB -
05nuzdn63lp28.js gzip N/A 155 B -
0arkbdqpxc37i.js gzip N/A 8.6 kB -
0tvekitj587fh.js gzip N/A 8.51 kB -
0z83a1om5rvtt.js gzip N/A 7.61 kB -
1-jqyfc89tixo.js gzip N/A 1.46 kB -
14j1fphnrcumo.js gzip N/A 156 B -
14t1kneseb8th.js gzip N/A 2.3 kB -
167oy01_iobb5.js gzip N/A 154 B -
192q2suy7rwb_.js gzip N/A 8.56 kB -
1ab2xruymo-oj.js gzip N/A 449 B -
1c_z8-k7lq1ex.js gzip N/A 70.8 kB -
1c5bs0lbhv0ju.js gzip N/A 65.5 kB -
1d5u5zkyjpm-c.js gzip N/A 156 B -
1wzrm0xjjbzn5.js gzip N/A 10.1 kB -
1xxdq0mlixixb.js gzip N/A 152 B -
1z-4q0hxrcdpe.js gzip N/A 157 B -
25a1yz7zua29z.js gzip N/A 13.8 kB -
2azcc-6jyax2b.js gzip N/A 157 B -
2ccdrb-lh2w0q.js gzip N/A 158 B -
2f2bp_kexa37v.js gzip N/A 13.3 kB -
2i5v1taq97gql.js gzip N/A 8.59 kB -
2lgky8-8vt_pi.js gzip N/A 162 B -
2n3vh0w0tnb_2.js gzip N/A 8.52 kB -
2r1_yk9dpqcg4.js gzip N/A 156 B -
2u_rpxq3tzytl.js gzip N/A 233 B -
2wfbykz1avdns.js gzip N/A 8.56 kB -
32sifemopndov.js gzip N/A 10.4 kB -
368lim5wq0o0r.js gzip N/A 12.9 kB -
37c5_hyr_xcxo.js gzip N/A 155 B -
3cjel_mp63mjd.js gzip N/A 166 B -
3de283pazbu99.js gzip N/A 9.81 kB -
3drqjohogojbw.js gzip N/A 5.69 kB -
3g8l1m2-o-ewi.js gzip N/A 13.1 kB -
3gp2o_v7jcw6s.js gzip N/A 8.57 kB -
3itv8l0nc6am0.js gzip N/A 153 B -
3qu7g1q2l_x2n.js gzip N/A 9.24 kB -
43j6fjudq0a3_.js gzip N/A 8.62 kB -
turbopack-0e..ymsk.js gzip N/A 4.19 kB -
turbopack-0k..y5p0.js gzip N/A 4.19 kB -
turbopack-0t..1-6l.js gzip N/A 4.19 kB -
turbopack-0x..avr6.js gzip N/A 4.19 kB -
turbopack-1g..303t.js gzip N/A 4.2 kB -
turbopack-1j..v-je.js gzip N/A 4.19 kB -
turbopack-1w..p32p.js gzip N/A 4.19 kB -
turbopack-1x..bzds.js gzip N/A 4.19 kB -
turbopack-2-..rz8q.js gzip N/A 4.19 kB -
turbopack-29..95qv.js gzip N/A 4.19 kB -
turbopack-2e..ehma.js gzip N/A 4.17 kB -
turbopack-2l..lpt0.js gzip N/A 4.19 kB -
turbopack-3-..a3i-.js gzip N/A 4.19 kB -
turbopack-36..qzj9.js gzip N/A 4.19 kB -
Total 465 kB 465 kB ⚠️ +36 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 716 B 719 B
Total 716 B 719 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 430 B 435 B 🔴 +5 B (+1%)
Total 430 B 435 B ⚠️ +5 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2637-HASH.js gzip 4.63 kB N/A -
7724.HASH.js gzip 169 B N/A -
8274-HASH.js gzip 61.3 kB N/A -
8817-HASH.js gzip 5.59 kB N/A -
c3500254-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 254 B 255 B
main-HASH.js gzip 39.4 kB 39.4 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
5887-HASH.js gzip N/A 5.61 kB -
6522-HASH.js gzip N/A 60.7 kB -
6779-HASH.js gzip N/A 4.63 kB -
8854.HASH.js gzip N/A 169 B -
eab920f9-HASH.js gzip N/A 62.8 kB -
Total 235 kB 235 kB ✅ -619 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 182 B 182 B
css-HASH.js gzip 333 B 334 B
dynamic-HASH.js gzip 1.81 kB 1.8 kB
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 353 B 349 B 🟢 4 B (-1%)
hooks-HASH.js gzip 384 B 382 B
image-HASH.js gzip 581 B 581 B
index-HASH.js gzip 260 B 259 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 316 B 318 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 313 B 314 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.97 kB ✅ -10 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB
page.js gzip 273 kB 272 kB
Total 398 kB 398 kB ✅ -382 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 618 B
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 43.7 kB 44.3 kB 🔴 +633 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B
Total 45.3 kB 45.9 kB ⚠️ +634 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 721 B 720 B
Total 721 B 720 B ✅ -1 B
Build Cache
Canary PR Change
0.pack gzip 4.38 MB 4.38 MB 🟢 4.57 kB (0%)
index.pack gzip 114 kB 112 kB 🟢 2.14 kB (-2%)
index.pack.old gzip 115 kB 114 kB
Total 4.61 MB 4.6 MB ✅ -7.51 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 346 kB 346 kB
app-page-exp..prod.js gzip 192 kB 192 kB
app-page-tur...dev.js gzip 346 kB 346 kB
app-page-tur..prod.js gzip 192 kB 192 kB
app-page-tur...dev.js gzip 342 kB 342 kB
app-page-tur..prod.js gzip 190 kB 190 kB
app-page.run...dev.js gzip 343 kB 343 kB
app-page.run..prod.js gzip 190 kB 190 kB
app-route-ex...dev.js gzip 77 kB 77 kB
app-route-ex..prod.js gzip 52.5 kB 52.5 kB
app-route-tu...dev.js gzip 77.1 kB 77.1 kB
app-route-tu..prod.js gzip 52.6 kB 52.6 kB
app-route-tu...dev.js gzip 76.7 kB 76.7 kB
app-route-tu..prod.js gzip 52.3 kB 52.3 kB
app-route.ru...dev.js gzip 76.6 kB 76.6 kB
app-route.ru..prod.js gzip 52.3 kB 52.3 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.9 kB 43.9 kB
pages-api-tu..prod.js gzip 33.5 kB 33.5 kB
pages-api.ru...dev.js gzip 43.9 kB 43.9 kB
pages-api.ru..prod.js gzip 33.5 kB 33.5 kB
pages-turbo....dev.js gzip 53.3 kB 53.3 kB
pages-turbo...prod.js gzip 39.1 kB 39.1 kB
pages.runtim...dev.js gzip 53.3 kB 53.3 kB
pages.runtim..prod.js gzip 39.1 kB 39.1 kB
server.runti..prod.js gzip 62.9 kB 62.9 kB
Total 3.06 MB 3.06 MB ✅ -2 B
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/90504c42f7c8a9b8adc0c00cd5b8d57a5029ea23/next

@mischnic mischnic marked this pull request as ready for review April 14, 2026 13:40
@mischnic mischnic requested a review from a team April 14, 2026 13:41
Comment thread turbopack/crates/turbopack-ecmascript/src/analyzer/graph.rs
@mischnic mischnic force-pushed the mischnic/refactor-esm-codegen branch 2 times, most recently from 24026b7 to 90504c4 Compare April 15, 2026 08:37
@mischnic mischnic force-pushed the mischnic/webpack-handling branch from c1078d2 to 8d134fd Compare April 15, 2026 08:37
@mischnic mischnic changed the base branch from mischnic/webpack-handling to graphite-base/92777 April 15, 2026 09:11
@mischnic mischnic force-pushed the graphite-base/92777 branch from 8d134fd to 7f3cfff Compare April 15, 2026 09:11
@mischnic mischnic force-pushed the mischnic/refactor-esm-codegen branch from 90504c4 to af22a46 Compare April 15, 2026 09:11
@graphite-app graphite-app Bot changed the base branch from graphite-base/92777 to canary April 15, 2026 09:12
@mischnic mischnic force-pushed the mischnic/refactor-esm-codegen branch from af22a46 to 41c3115 Compare April 15, 2026 09:12
@mischnic mischnic merged commit b6cf70e into canary Apr 15, 2026
185 of 189 checks passed
Copy link
Copy Markdown
Member Author

Merge activity

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants