Turbopack: remove StarImportAnalyzer#92830
Merged
Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 15, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Merging this PR will improve performance by 3.86%
Performance Changes
Comparing 
Footnotes
|
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
mischnic
changed the base branch from
mischnic/refactor-export-analysis
to
graphite-base/92830
mischnic
force-pushed
the
graphite-base/92830
branch
from
3de5acb to
de62a96
Compare
mischnic
force-pushed
the
mischnic/remove-StarImportAnalyzer
branch
from
50ce3fd to
658ec6f
Compare
mischnic
force-pushed
the
mischnic/remove-StarImportAnalyzer
branch
2 times, most recently
from
c9bff2a to
14aab78
Compare
Contributor
Tests Passed |
| let callee_span = match &n.callee { | ||
| box Expr::Ident(Ident { sym, .. }) if sym == "Worker" => Some(n.span), | ||
| let callee_span = match &*n.callee { | ||
| Expr::Ident(Ident { sym, .. }) if sym == "Worker" => Some(n.span), |
Contributor
There was a problem hiding this comment.
this is a little weird right? should we check that this is an unresolved id as well? or i guess over matching is no big deal, but what about aliasing?
Member
Author
There was a problem hiding this comment.
this is the match on the parsing of the comment
and the actual JsValue-based logic will be a proper analysis.
but you're right, if you alias Worker to a different variable, then the comment wouldn't work.
lukesandberg
approved these changes
Apr 15, 2026
mischnic
force-pushed
the
mischnic/remove-StarImportAnalyzer
branch
from
14aab78 to
e489805
Compare
mischnic
force-pushed
the
mischnic/remove-StarImportAnalyzer
branch
from
e489805 to
487822d
Compare
Member
Author
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is actually no reason to compute
full_star_importsbefore thevisit_with(&mut analyzer): it's only used later on by references/mod.rs which callsshould_import_all.So we can just do it in the same traversal