fix(config): don't resolve by module field#10347
Merged
patak-dev merged 1 commit intovitejs:mainfrom Oct 5, 2022
Merged
Conversation
patak-dev
approved these changes
Oct 5, 2022
Contributor
|
@patak-dev just noticed this with |
bluwy
pushed a commit
that referenced
this pull request
Oct 6, 2022
patak-dev
pushed a commit
that referenced
this pull request
Oct 6, 2022
9 tasks
This was referenced Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rollup plugins declares module field.
https://github.com/rollup/plugins/blob/4e85ed78cd2e941107fdf0e8e118e7bee550109d/packages/yaml/package.json#L17
But this field could resolve to
.jsfiles and this cannot be externalized because it will be treated as CJS by node.This PR changes
mainFieldsto be[]so thatmodulefield won't be used when a module is externalized.reproduction
related: #10254
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).