Skip to content

fix(config): don't use module condition (import.meta.resolve) (fixes #10430)#10528

Merged
patak-dev merged 2 commits intovitejs:mainfrom
sapphi-red:fix/config-import-meta-resolve
Oct 20, 2022
Merged

fix(config): don't use module condition (import.meta.resolve) (fixes #10430)#10528
patak-dev merged 2 commits intovitejs:mainfrom
sapphi-red:fix/config-import-meta-resolve

Conversation

@sapphi-red
Copy link
Member

Description

Alternative to #10495. See #10495.

superseds #10442 #10495
fixes #10430
refs #10254 #10347 #10420

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 19, 2022
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 19, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev added this to the 3.2 milestone Oct 19, 2022
@patak-dev patak-dev requested a review from bluwy October 19, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p4-important Violate documented behavior or significantly improves performance (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite >=3.1.5 breaks Jotai babel plugins

3 participants

Comments