Skip to content

fix(resolve): ensure exports has precedence over mainFields#11234

Merged
patak-cat merged 1 commit into
mainfrom
fix-resolve-export-precedence
Dec 7, 2022
Merged

fix(resolve): ensure exports has precedence over mainFields#11234
patak-cat merged 1 commit into
mainfrom
fix-resolve-export-precedence

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Dec 7, 2022

Description

If the exports field returns a file path that ends with .mjs, mainFields will take precendence over it. This breaks how nodejs resolve and blocks svelte's node condition from being used.

Additional context

Feels a bit late to push this, but I tried to make the smallest change possible to fix this bug specifically, which shouldn't break existing logic.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 7, 2022
@patak-cat patak-cat merged commit d6eb4f2 into main Dec 7, 2022
@patak-cat patak-cat deleted the fix-resolve-export-precedence branch December 7, 2022 13:34
dominikg added a commit to dominikg/vite that referenced this pull request Dec 8, 2022
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants