Skip to content

fix(resolve): revert ensure exports has precedence over mainFields (#11234)#11270

Merged
patak-cat merged 1 commit into
vitejs:mainfrom
dominikg:revert/exports-over-mainfields-mjs
Dec 8, 2022
Merged

fix(resolve): revert ensure exports has precedence over mainFields (#11234)#11270
patak-cat merged 1 commit into
vitejs:mainfrom
dominikg:revert/exports-over-mainfields-mjs

Conversation

@dominikg
Copy link
Copy Markdown
Contributor

@dominikg dominikg commented Dec 8, 2022

This reverts commit d6eb4f2.

ecosystem-ci had a fail from histoire and bisect pointed at that commit. lets see if undoing helps.

note this is going to fail svelte tests as we have to undo an optimization based on the commit to revert.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg
Copy link
Copy Markdown
Contributor Author

dominikg commented Dec 8, 2022

/ecosystem-ci run histoire

@vite-ecosystem-ci
Copy link
Copy Markdown

vite-ecosystem-ci Bot commented Dec 8, 2022

📝 Ran ecosystem CI: Open

suite result
histoire ✅ success

@patak-cat
Copy link
Copy Markdown
Member

Thanks for helping us go through the more stable route for the ecosystem here @dominikg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants