feat(plugin-react-refresh): support configure babel plugins#3319
Closed
underfin wants to merge 4 commits into
Closed
feat(plugin-react-refresh): support configure babel plugins#3319underfin wants to merge 4 commits into
underfin wants to merge 4 commits into
Conversation
kjeske
reviewed
May 9, 2021
antfu
reviewed
May 9, 2021
| ```js | ||
| export default { | ||
| plugins: [reactRefresh({ | ||
| plugins: ['@emotion/babel-plugin'] |
Member
There was a problem hiding this comment.
Suggested change
| plugins: ['@emotion/babel-plugin'] | |
| babelPlugins: ['@emotion/babel-plugin'] |
Should we be more explicit here?
Member
Author
There was a problem hiding this comment.
I think plugins is ok, like parserPlugins. The users should be aware the react-refresh is construct on babel.
reactRefresh({
parserPlugins: [
'classProperties',
'classPrivateProperties'
]
})
Shinigami92
reviewed
May 10, 2021
|
Thanks for the PR! How the process will follow from now with the review and merging? It's just waiting in the queue? Who prioritizes the PRs for reviewing and then merging? |
Shinigami92
approved these changes
May 20, 2021
nihalgonsalves
approved these changes
May 26, 2021
Member
|
After the discussion with Evan, we planed to rename /cc @aleclarson would you like to take care of the renaming and migrate process? |
13 tasks
Contributor
Member
|
Close in favor of #3588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3276
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).