refactor!: migrate plugin-react-refresh to plugin-react#3588
Conversation
|
I added now the new label |
plugin-react-refresh to plugin-react
|
Thanks @aleclarson for your work in that PR, it's something I'm really looking forward to :) What is the status of the works? |
|
@kjeske It should be ready for use. To get this merged, someone needs to setup some tests in Specifically, playground/react should be migrated to use |
|
|
Shinigami92
left a comment
There was a problem hiding this comment.
getJSXNode, getJSXName, getJSXProps and getJSXChildren feels a bit to wide open 🤔
Maybe they can benefit from using generic arguments
|
It might be better to copy over the unit tests from here instead of trying to perfect the types. I don't expect much future development of |
|
Okay, so I'm glad that I just was bored yesterday 😄 |
|
What's missing now in this PR to be completed? |
|
@kjeske See the todos in the OP. Feel free to open a PR targeting this one if you decide to help out 😃 |
This reverts commit f9006ba.
This dependency is minified and commonjs, which will test the capabilities of the `restoreJSX` function.
Also: - check `jsxInject` inside configResolved - ensure all config values have reasonable defaults for Rollup compatibility
Co-authored-by: Shinigami <chrissi92@hotmail.de>
287bd3e to
bfd5a9a
Compare
See #3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>
See #3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>
See #3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>
See vitejs#3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>
See vitejs#3588 for full commit history Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Peng Xiao <pengxiao@outlook.com>
Description
Once this plugin is released,
@vitejs/plugin-react-refreshshould be deprecated.This plugin will do the following:
plugin-react-refresh)vite-react-jsxis also usedStatus
Almost ready to ship 🚢
Remaining questions
jsxRuntime: "automatic"be the default?plugin-react/CHANGELOG.md?Todo
./packages/playground(in progress by @pengx17)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).