Skip to content

fix: fix errors caused by comments (fix #3542)#3569

Closed
javastation wants to merge 1 commit into
vitejs:mainfrom
javastation:main
Closed

fix: fix errors caused by comments (fix #3542)#3569
javastation wants to merge 1 commit into
vitejs:mainfrom
javastation:main

Conversation

@javastation
Copy link
Copy Markdown
Contributor

@javastation javastation commented May 27, 2021

Description

Like #3542 , add parserPlugins argument when calling rewriteDefault to resolve the error causing by comments including export default

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@underfin
Copy link
Copy Markdown
Member

Thanks for your pr, but this can avoid extra babel compiled for ts, because it will be tranformed at esbuild. I open a pr at #3591, if you has other advice, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants