fix(plugin-vue): rewrite default after ts compiled#3591
Merged
Conversation
9 tasks
patak-cat
previously approved these changes
May 30, 2021
Member
|
Independently from this PR, should the replacements for the class check logic also update the source map? (i.e. using magic string for scriptCode) |
Shinigami92
reviewed
May 30, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Member
Author
|
@patak-js i removed class check. The sourcemap shouldn‘t affect for users, becuase only has cloumn changed, if this line has some error, the users also can realize error and fix it. |
Shinigami92
approved these changes
May 30, 2021
Member
|
@underfin the class check can now be safely removed because |
antfu
approved these changes
May 31, 2021
ygj6
pushed a commit
to ygj6/vite
that referenced
this pull request
Jun 1, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Contributor
|
updating from @vitejs/plugin-vue@1.2.2 to @vitejs/plugin-vue@1.2.3 throws an error for me: If I had any clue where this came from, I'd post it here but I have no idea how to reproduce it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #3542
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).