Skip to content

fix(plugin-vue): rewrite default after ts compiled#3591

Merged
antfu merged 5 commits into
mainfrom
fix-rewrite-default
Jun 1, 2021
Merged

fix(plugin-vue): rewrite default after ts compiled#3591
antfu merged 5 commits into
mainfrom
fix-rewrite-default

Conversation

@underfin
Copy link
Copy Markdown
Member

fix: #3542

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-cat
patak-cat previously approved these changes May 30, 2021
@antfu antfu requested a review from haoqunjiang May 30, 2021 06:58
@patak-cat
Copy link
Copy Markdown
Member

Independently from this PR, should the replacements for the class check logic also update the source map? (i.e. using magic string for scriptCode)

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 30, 2021
Comment thread packages/playground/vue/CustomBlock.vue Outdated
@underfin
Copy link
Copy Markdown
Member Author

@patak-js i removed class check. The sourcemap shouldn‘t affect for users, becuase only has cloumn changed, if this line has some error, the users also can realize error and fix it.

@patak-cat
Copy link
Copy Markdown
Member

@underfin the class check can now be safely removed because @vue/compiler-sfc has been updated as indicated in the comment?

@Shinigami92 Shinigami92 requested a review from patak-cat May 30, 2021 12:04
@antfu antfu merged commit ea5bafa into main Jun 1, 2021
@antfu antfu deleted the fix-rewrite-default branch June 1, 2021 00:00
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@hmt
Copy link
Copy Markdown
Contributor

hmt commented Jun 10, 2021

updating from @vitejs/plugin-vue@1.2.2 to @vitejs/plugin-vue@1.2.3 throws an error for me:

Uncaught SyntaxError: duplicate export name 'default'

If I had any clue where this came from, I'd post it here but I have no idea how to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The combination of specific statements and comments can cause errors (vite & vite build)

5 participants