Skip to content

fix(ui,browser): load panel sizes from storage on initial load #7265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 1 commit into from
Apr 17, 2025
Merged

fix(ui,browser): load panel sizes from storage on initial load #7265

sheremet-va merged 1 commit into from
Apr 17, 2025

Conversation

@userquin
Copy link
Member

@userquin userquin commented Jan 16, 2025 •
edited
Loading

Description

The problem was about restoring the sizes using @ready event in the root split pane: there was some race condition between local storage and the event handling.

There is also similar problem with the Hide/Show Right Panel button in browser mode when hidding the right panel and initial load or page refresh: showing Hide Right Panel button instead Show Right Panel.

This PR also includes:

  • use resize observer in Explorer.vue to change the filter based on its width instead on main and panels sizes: on initial load or page refresh sometimes the filter with wrong grid columns (the filter will not change while resizing until resized).
  • increase the navigator percentage to 15% in BrowserIFrame.vue to show the Show Navigation Panel button (browser mode).

closes #6678
supersedes #6679

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@userquin userquin requested a review from sheremet-va January 16, 2025 15:23
@sheremet-va sheremet-va merged commit 6555d61 into main Apr 17, 2025
13 checks passed
@sheremet-va sheremet-va deleted the userquin/fix-splitpanes branch April 17, 2025 13:51
@userquin userquin mentioned this pull request Apr 19, 2025
Closed
6 tasks
schogges pushed a commit to kumahq/kuma-gui that referenced this pull request Apr 23, 2025
@dependabot
chore(deps-dev): Bump vitest from 3.1.1 to 3.1.2 (#3781)
ecaab5d 
v3.1.2
   🐞 Bug Fixes
Add global chai variable in vitest/globals (fix: #7474)  -  by @​Jay-Karia in vitest-dev/vitest#7771 and vitest-dev/vitest#7474 (d9297)
Prevent modifying test.exclude when same object passed in coverage.exclude  -  by @​AriPerkkio in vitest-dev/vitest#7774 (c3751)
Fix already hoisted mock  -  by @​hi-ogawa in vitest-dev/vitest#7815 (773b1)
Fix test.scoped inheritance  -  by @​hi-ogawa in vitest-dev/vitest#7814 (db6c3)
Remove pointer-events-none after resizing the left panel  -  by @​alexprudhomme in vitest-dev/vitest#7811 (a7e77)
Default to run mode when stdin is not a TTY  -  by @​kentonv, @​hi-ogawa and @​sheremet-va in vitest-dev/vitest#7673 (6358f)
Use happy-dom/jsdom types for envionmentOptions  -  by @​hi-ogawa in vitest-dev/vitest#7795 (67430)
browser:
Fix transform error before browser server initialization  -  by @​hi-ogawa in vitest-dev/vitest#7783 (5f762)
Fix mocking from outside of root  -  by @​hi-ogawa in vitest-dev/vitest#7789 (03f55)
Scale iframe for non ui case  -  by @​hi-ogawa in vitest-dev/vitest#6512 (c3374)
coverage:
await profiler calls  -  by @​AriPerkkio in vitest-dev/vitest#7763 (795a6)
Expose profiling timers  -  by @​AriPerkkio in vitest-dev/vitest#7820 (5652b)
deps:
Update all non-major dependencies  -  in vitest-dev/vitest#7765 (7c3df)
Update all non-major dependencies  -  in vitest-dev/vitest#7831 (15701)
runner:
Correctly call test hooks and teardown functions  -  by @​sheremet-va in vitest-dev/vitest#7775 (3c00c)
Show stacktrace on test timeout error  -  by @​hi-ogawa in vitest-dev/vitest#7799 (df33b)
ui:
Load panel sizes from storage on initial load  -  by @​userquin in vitest-dev/vitest#7265 (6555d)
vite-node:
Named export should overwrite export all  -  by @​hi-ogawa in vitest-dev/vitest#7846 (5ba0d)
Add ERR_MODULE_NOT_FOUND code error if module cannot be loaded  -  by @​sheremet-va in vitest-dev/vitest#7776 (f9eac)
   🏎 Performance
browser: Improve browser parallelisation  -  by @​sheremet-va in vitest-dev/vitest#7665 (816a5)
This was referenced May 2, 2025
Closed
Merged
This was referenced May 23, 2025
Open
Open
@renovate renovate bot mentioned this pull request Jun 9, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Jun 30, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request Sep 20, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI splitpanes sizes are no longer persisted to local storage

3 participants

@userquin @sheremet-va