Skip to content

fix(runner): correctly call test hooks and teardown functions #7775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 4 commits into from
Apr 2, 2025
Merged

fix(runner): correctly call test hooks and teardown functions #7775

sheremet-va merged 4 commits into from
Apr 2, 2025

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 1, 2025 •
edited
Loading

Description

Fixes #7493
Fixes #7768

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title fix(runner): teardown functions follow the sequence.hooks config option fix(runner): teardown functions follow the sequence.hooks config option Apr 1, 2025
@netlify
Copy link

netlify bot commented Apr 1, 2025

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit d60cffc
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67ebd20366e5d500089d0ee3
😎 Deploy Preview https://deploy-preview-7775--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va changed the title fix(runner): teardown functions follow the sequence.hooks config option fix(runner): correctly call test hooks and teardown functions Apr 1, 2025
@sheremet-va sheremet-va requested a review from hi-ogawa April 1, 2025 12:48
hi-ogawa
hi-ogawa approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sheremet-va sheremet-va merged commit 3c00c87 into vitest-dev:main Apr 2, 2025
12 of 13 checks passed
@sheremet-va sheremet-va deleted the fix/correctly-call-cleanup branch April 3, 2025 13:13
@renovate renovate bot mentioned this pull request Apr 22, 2025
Open
1 task
schogges pushed a commit to kumahq/kuma-gui that referenced this pull request Apr 23, 2025
@dependabot
chore(deps-dev): Bump vitest from 3.1.1 to 3.1.2 (#3781)
ecaab5d 
v3.1.2
   🐞 Bug Fixes
Add global chai variable in vitest/globals (fix: #7474)  -  by @​Jay-Karia in vitest-dev/vitest#7771 and vitest-dev/vitest#7474 (d9297)
Prevent modifying test.exclude when same object passed in coverage.exclude  -  by @​AriPerkkio in vitest-dev/vitest#7774 (c3751)
Fix already hoisted mock  -  by @​hi-ogawa in vitest-dev/vitest#7815 (773b1)
Fix test.scoped inheritance  -  by @​hi-ogawa in vitest-dev/vitest#7814 (db6c3)
Remove pointer-events-none after resizing the left panel  -  by @​alexprudhomme in vitest-dev/vitest#7811 (a7e77)
Default to run mode when stdin is not a TTY  -  by @​kentonv, @​hi-ogawa and @​sheremet-va in vitest-dev/vitest#7673 (6358f)
Use happy-dom/jsdom types for envionmentOptions  -  by @​hi-ogawa in vitest-dev/vitest#7795 (67430)
browser:
Fix transform error before browser server initialization  -  by @​hi-ogawa in vitest-dev/vitest#7783 (5f762)
Fix mocking from outside of root  -  by @​hi-ogawa in vitest-dev/vitest#7789 (03f55)
Scale iframe for non ui case  -  by @​hi-ogawa in vitest-dev/vitest#6512 (c3374)
coverage:
await profiler calls  -  by @​AriPerkkio in vitest-dev/vitest#7763 (795a6)
Expose profiling timers  -  by @​AriPerkkio in vitest-dev/vitest#7820 (5652b)
deps:
Update all non-major dependencies  -  in vitest-dev/vitest#7765 (7c3df)
Update all non-major dependencies  -  in vitest-dev/vitest#7831 (15701)
runner:
Correctly call test hooks and teardown functions  -  by @​sheremet-va in vitest-dev/vitest#7775 (3c00c)
Show stacktrace on test timeout error  -  by @​hi-ogawa in vitest-dev/vitest#7799 (df33b)
ui:
Load panel sizes from storage on initial load  -  by @​userquin in vitest-dev/vitest#7265 (6555d)
vite-node:
Named export should overwrite export all  -  by @​hi-ogawa in vitest-dev/vitest#7846 (5ba0d)
Add ERR_MODULE_NOT_FOUND code error if module cannot be loaded  -  by @​sheremet-va in vitest-dev/vitest#7776 (f9eac)
   🏎 Performance
browser: Improve browser parallelisation  -  by @​sheremet-va in vitest-dev/vitest#7665 (816a5)
This was referenced Apr 24, 2025
Merged
Merged
Merged
This was referenced May 5, 2025
Closed
Merged
This was referenced May 17, 2025
Open
Closed
AriPerkkio added a commit to AriPerkkio/vitest that referenced this pull request Jun 4, 2025
@AriPerkkio
Revert "fix(runner): correctly call test hooks and teardown functions (…
d77c746 
…vitest-dev#7775)"

This reverts commit 3c00c87.
This was referenced Jun 8, 2025
Open
Open
@renovate renovate bot mentioned this pull request Jun 24, 2025
Open
1 task
@renovate renovate bot mentioned this pull request Jul 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@sheremet-va @hi-ogawa