Weird behaviour in flag interaction when creating workload from git source

[warango4]

Please fill out the issue checklist below and provide ALL the requested information.

• I reviewed open and closed Github issues that may be related to my problem.
• I am reporting a bug that others will be able to reproduce.

Describe the bug

A clear and concise description of what the bug is.

When creating a workload from git source, it is allowed to set git tag, git branch and git commit. When not setting at least one of those there is a message saying

[--git-branch, --git-tag]: Required value: expected exactly one, got neither

This can be misleading for user and wouldn't know what's actually the way a workload should be created.

Also, when updating commit field, tag field is deleted. Same if updating tag, then commit would be deleted

WHEN UPDATING COMMIT

WHEN UPDATING TAG

Steps to Reproduce

Steps to reproduce the behavior:

• Create a workload

tanzu apps workload create pet-clinic --git-repo https://github.com/sample-accelerators/spring-petclinic --type web --app spring-petclinic --git-commit 123 --git-branch main

• Update the workload

tanzu apps workload update pet-clinic  --git-tag tap-1.2

• Delete the workload

tanzu apps workload delete pet-clinic -y

• Create the workload without --git-tag, --git-commit and --git-branch
  See the error

Error: [--git-branch, --git-tag]: Required value: expected exactly one, got neither
Error: exit status 1

Screenshots

If applicable, add screenshots to help explain your problem.

Version (Apps plugin version, Version of K8s running on cluster)

Put the output of the following commad

tanzu version && tanzu apps version

version: v0.11.1
buildDate: 2022-02-14
sha: 4d578570
v0.0.0-dev

Environment where the bug was observed (cloud, OS, etc)

Additional context & Relevant Debug Output (Logs, etc)

Add any other context about the problem here.

[heyjcollins]

when updating commit field, tag field is deleted. Same if updating tag, then commit would be deleted

In practice, isn't providing commit AND tag redundant?
Should they be exclusive?
If both commit and tag are allowed, it's possible to pass a commit value that doesn't align with the tag.
And although it looks as if the build succeeds, it's unclear which code iteration was compiled.

[warango4]

@heyjcollins so we should not allow to specify a tag alongside a commit?
I ask this because, from my point of view, it'd be unclear to the user why they were allowed to create the workload with both commit and tag but then, when they update, these fields are not allowed to go together.