fix: Allow user to pass only git commit for git ref#423
Merged
warango4 merged 1 commit intovmware-tanzu:mainfrom Jan 17, 2023
Merged
fix: Allow user to pass only git commit for git ref#423warango4 merged 1 commit intovmware-tanzu:mainfrom
warango4 merged 1 commit intovmware-tanzu:mainfrom
Conversation
Contributor
|
git* flag validation can be removed given we can't predict the downstream behavior of FluxCD (or some other orchestrator configured in the supply chain). |
Signed-off-by: Wendy Arango <warango@vmware.com>
anibmurthy
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Because of a FluxCD bug, apps plugin would not allow users to pass a git commit to take the source from when creating a workload, so there was always a need to specify either
--git-branchor--git-tag. There is an upstream fix in the newer versions of FluxCD and TAP has been updated to use the latest (v0.17.1+), so apps plugin can also be updated to allow users to create their workload using only--git-commitWhich issue(s) this PR fixes
Fixes #179
Fixes #28
Describe testing done for PR
--git-commit,--git-tag,--git-branch), each separated, and combination of these.Additional information or special notes for your reviewer
Signed-off-by: Wendy Arango warango@vmware.com