Vch guest operations multi vch [full ci]#6956
Closed
hickeng wants to merge 20 commits intovmware:masterfrom
Closed
Vch guest operations multi vch [full ci]#6956hickeng wants to merge 20 commits intovmware:masterfrom
hickeng wants to merge 20 commits intovmware:masterfrom
Conversation
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
4 times, most recently
from
920afad to
5a80737
Compare
This adds neat shutdown support in the endpointVM: * cleans up Views, Managers and sessions in portlayer * cleans up session in personality *** vicadmin still leaves session behind (only after active use) Reduces excessive log verbosity Unifies diskmanager usage on a single instance for the storage component. This is mostly unrelated but is the correct usage given locking assumptions.
Updates the way tether waits for sessions to exit. Updates vic-machine to use guest shutdown for endpointVM Updates vicadmin to not invalidate sessions on validation errors, to log out reaped or deleted sessions, and to delete all on exit
hickeng
changed the title
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
2 times, most recently
from
7c40d5c to
f8c9142
Compare
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
from
f8c9142 to
9e107bf
Compare
hickeng
changed the title
hickeng
changed the title
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
2 times, most recently
from
1ca5041 to
328c736
Compare
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
from
1116a35 to
af52f93
Compare
This reverts commit 2a0f777.
hickeng
changed the title
Speculative that there are two issues: 1. leaking VCHs from group23 2. event page size Hypothesis is that either of those can result in builds overwhelming hostd and the combination has made addressing one in isolation return false negatives for impact. This reverts commit 7796336.
hickeng
force-pushed
the
vchGuestOperations-multi-vch
branch
from
2746b1c to
268e165
Compare
This was referenced Dec 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variant of #6955
This reverts to multiple VCHs for group1 to see if the rotation of sessions allows hostd to GC the events and tasks.