Increase event page size to 1000#6937
Merged
mdubya66 merged 1 commit intovmware:masterfrom Dec 10, 2017
Merged
Conversation
Increasing the event page size on the portlayer to help with missing events. Helps with vmware#6384, vmware#6851
sflxn
approved these changes
Dec 8, 2017
hickeng
approved these changes
Dec 8, 2017
Contributor
|
Could you run test |
Contributor
Author
|
@hickeng ran that test locally and am concerned by the amount of event spew on VCH startup -- the event collector is created and the last 1K events on that host / cluster before it's powerOn will be seen by the VCH. That could be helpful in avoiding missed events in the case of an outage, but unhelpful when it's a new VCH. In the case of a new VCH we'll log and callback for many events that have nothing to do with the VCH. It added about 70KB to the portLayer log... |
cgtexmex
pushed a commit
to cgtexmex/vic
that referenced
this pull request
Dec 13, 2017
Increasing the event page size on the portlayer to help with missing events. Helps with vmware#6384, vmware#6851
mhagen-vmware
pushed a commit
that referenced
this pull request
Dec 13, 2017
mdharamadas1
added a commit
to mdharamadas1/vic
that referenced
this pull request
Dec 15, 2017
This reverts commit 7796336.
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Dec 21, 2017
Speculative that there are two issues: 1. leaking VCHs from group23 2. event page size Hypothesis is that either of those can result in builds overwhelming hostd and the combination has made addressing one in isolation return false negatives for impact. This reverts commit 7796336.
hickeng
pushed a commit
to hickeng/vic
that referenced
this pull request
Dec 21, 2017
Increasing the event page size on the portlayer to help with missing events. Helps with vmware#6384, vmware#6851
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Dec 21, 2017
Speculative that there are two issues: 1. leaking VCHs from group23 2. event page size Hypothesis is that either of those can result in builds overwhelming hostd and the combination has made addressing one in isolation return false negatives for impact. This reverts commit 7796336.
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Dec 21, 2017
This reverts commit 7796336 because it's apparent that increasing the page size to this extent can cause hostd to both hit its resource limits and to drastically fragment its heap.
hickeng
added a commit
that referenced
this pull request
Dec 21, 2017
* Fix leak of VCHs after test runs The delete tests for vic-machine and vic-machine-service leaks VCHs. For the service it's because the tests deploy VCHs directly that are not cleaned up. For vic-machine base it's because we render the VCH invalid by moving the endpointVM in such a manner that the deletion fails without explicit cleanup after. * Revert "Increase event page size to 1000 (#6937)" This reverts commit 7796336 because it's apparent that increasing the page size to this extent can cause hostd to both hit its resource limits and drastically fragment its heap.
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Dec 21, 2017
* Fix leak of VCHs after test runs The delete tests for vic-machine and vic-machine-service leaks VCHs. For the service it's because the tests deploy VCHs directly that are not cleaned up. For vic-machine base it's because we render the VCH invalid by moving the endpointVM in such a manner that the deletion fails without explicit cleanup after. * Revert "Increase event page size to 1000 (vmware#6937)" This reverts commit 7796336 because it's apparent that increasing the page size to this extent can cause hostd to both hit its resource limits and drastically fragment its heap.
hickeng
added a commit
that referenced
this pull request
Dec 21, 2017
* Fix leak of VCHs after test runs The delete tests for vic-machine and vic-machine-service leaks VCHs. For the service it's because the tests deploy VCHs directly that are not cleaned up. For vic-machine base it's because we render the VCH invalid by moving the endpointVM in such a manner that the deletion fails without explicit cleanup after. * Revert "Increase event page size to 1000 (#6937)" This reverts commit 7796336 because it's apparent that increasing the page size to this extent can cause hostd to both hit its resource limits and drastically fragment its heap.
hickeng
pushed a commit
to hickeng/vic
that referenced
this pull request
Dec 29, 2017
An alternative to increasing the collector page size. It will reduce the throughput to the event collector and hence reduce event misses. See issues vmware#6937 and vmware#6998
hickeng
pushed a commit
to hickeng/vic
that referenced
this pull request
Dec 29, 2017
An alternative to increasing the collector page size. It will reduce the throughput to the event collector and hence reduce event misses. See issues vmware#6937 and vmware#6998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing the event page size on the portlayer
to help with missing events.
Helps with #6384, #6851