Fix hostd resource exhaustion in high load CI (#6998)#6999
Merged
hickeng merged 1 commit intovmware:releases/1.3.0from Dec 21, 2017
Merged
Fix hostd resource exhaustion in high load CI (#6998)#6999hickeng merged 1 commit intovmware:releases/1.3.0from
hickeng merged 1 commit intovmware:releases/1.3.0from
Conversation
* Fix leak of VCHs after test runs The delete tests for vic-machine and vic-machine-service leaks VCHs. For the service it's because the tests deploy VCHs directly that are not cleaned up. For vic-machine base it's because we render the VCH invalid by moving the endpointVM in such a manner that the deletion fails without explicit cleanup after. * Revert "Increase event page size to 1000 (vmware#6937)" This reverts commit 7796336 because it's apparent that increasing the page size to this extent can cause hostd to both hit its resource limits and drastically fragment its heap.
cgtexmex
approved these changes
Dec 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete tests for vic-machine and vic-machine-service leaks VCHs.
For the service it's because the tests deploy VCHs directly that are not
cleaned up.
For vic-machine base it's because we render the VCH invalid by moving the
endpointVM in such a manner that the deletion fails without explicit
cleanup after.
This reverts commit 7796336 because it's
apparent that increasing the page size to this extent can cause hostd to
both hit its resource limits and drastically fragment its heap.