[full ci] Revert govc changes and update event page value#6970
Closed
mdharamadas1 wants to merge 4 commits intovmware:masterfrom
Closed
[full ci] Revert govc changes and update event page value#6970mdharamadas1 wants to merge 4 commits intovmware:masterfrom
mdharamadas1 wants to merge 4 commits intovmware:masterfrom
Conversation
mdharamadas1
changed the title
mdharamadas1
force-pushed
the
revert-govc-eventpage-changes
branch
from
82b855a to
393540c
Compare
Contributor
|
Why the revert? |
Contributor
Author
|
@cgtexmex Sorry, didn't mention earlier but this is just for testing purpose as requested by @mhagen-vmware |
Contributor
|
so why revert from master and pollute the git history? Can't we use a different branch? Or is this a CI / Testing limitation? |
Contributor
|
Not going to merge it, just testing |
Contributor
|
Merging this will break some of the tests in #6816 so those will need to be disabled or something |
mdharamadas1
force-pushed
the
revert-govc-eventpage-changes
branch
from
393540c to
a17b64c
Compare
mdharamadas1
changed the title
Contributor
Author
|
All, I have updated the description for this PR. |
mdharamadas1
force-pushed
the
revert-govc-eventpage-changes
branch
from
a17b64c to
b6ef0d6
Compare
andrewtchin
approved these changes
Dec 18, 2017
Contributor
|
#6998 addressed this |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "Increase event page size to 1000 (#6937)Change event page size to 300
Revert "Integration image govc v0.16.0 (#6788)"
Add GitHub check to two failing vic machine tests