session: Note operations which omit UserAgent#7887
Merged
zjs merged 2 commits intovmware:masterfrom May 7, 2018
Merged
Conversation
jzt
approved these changes
May 4, 2018
zjs
force-pushed
the
topic/refactor-session-split/user-agent
branch
from
7e86a70 to
7cf8170
Compare
zjs
force-pushed
the
topic/refactor-session-split/user-agent
branch
from
7cf8170 to
6e56d15
Compare
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so.
zjs
force-pushed
the
topic/refactor-session-split/user-agent
branch
from
6e56d15 to
6e51ea6
Compare
cgtexmex
approved these changes
May 4, 2018
Codecov Report
@@ Coverage Diff @@
## master #7887 +/- ##
==========================================
- Coverage 31.3% 26.34% -4.97%
==========================================
Files 295 37 -258
Lines 43675 5189 -38486
==========================================
- Hits 13674 1367 -12307
+ Misses 28817 3715 -25102
+ Partials 1184 107 -1077Continue to review full report at Codecov.
|
AngieCris
approved these changes
May 7, 2018
2 tasks
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 21, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 22, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jun 28, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Jul 2, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Jul 25, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR vmware#7887
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Aug 2, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR vmware#7887
hickeng
added a commit
that referenced
this pull request
Aug 8, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR #7887
zjs
added a commit
to zjs/vic
that referenced
this pull request
Aug 10, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Aug 10, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR vmware#7887 (cherry picked from commit 686535b)
zjs
added a commit
to zjs/vic
that referenced
this pull request
Aug 10, 2018
) Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Aug 10, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR vmware#7887 (cherry picked from commit 686535b)
zjs
added a commit
that referenced
this pull request
Aug 10, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
zjs
pushed a commit
that referenced
this pull request
Aug 10, 2018
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR #7887 (cherry picked from commit 686535b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log a message (at debug, since this indicates a programming error, not
something a user could address) any time we create a Session without
specifying a UserAgent.
Specify a UserAgent in several places where we were not doing so.
Towards: #6032