User-agent related cherry-picks for 1.4.3#8206
Merged
zjs merged 2 commits intovmware:releases/1.4.3from Aug 10, 2018
Merged
Conversation
) Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
This ensures that each vmomi client has a unique user-agent string so it is possible to link vmomi sessions back to the originating component within a VCH. The only user-agent that needed updating was the one used to pull project specific configuration from admiral/harbor. This follows on from PR vmware#7887 (cherry picked from commit 686535b)
lcastellano
approved these changes
Aug 10, 2018
hickeng
approved these changes
Aug 10, 2018
zjs
added a commit
that referenced
this pull request
Aug 10, 2018
Log a message (at debug, since this indicates a programming error, not something a user could address) any time we create a Session without specifying a UserAgent. Specify a UserAgent in several places where we were not doing so. (cherry picked from commit ff1db6e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session: Note operations which omit UserAgent (#7887)
Log a message (at debug, since this indicates a programming error, not
something a user could address) any time we create a Session without
specifying a UserAgent.
Specify a UserAgent in several places where we were not doing so.
(cherry picked from commit ff1db6e)
Update admiral user-agent to allow differentiation
This ensures that each vmomi client has a unique user-agent string so it
is possible to link vmomi sessions back to the originating component
within a VCH. The only user-agent that needed updating was the one used to
pull project specific configuration from admiral/harbor.
This follows on from PR #7887
(cherry picked from commit 686535b)
Like any PR which cherry-picks multiple commits, this should be merged using the "Rebase & Merge" option (not "Squash & Merge").