Integration test script refinement and fixes [skip ci]#8063
Merged
hickeng merged 3 commits intovmware:masterfrom Jun 16, 2018
Merged
Integration test script refinement and fixes [skip ci]#8063hickeng merged 3 commits intovmware:masterfrom
hickeng merged 3 commits intovmware:masterfrom
Conversation
359c80d to
3b1d40a
Compare
1. correct link construction for download of log bundles 2. correct custom test bed specified case in nimbus utils 3. clean generated log file name
The spec has been moved to the end to reduce the changes necessary in calls to the Nimbus Deploy Testbed keyword that do not specify a custom testbed file.
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Jun 17, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it is addressing removal of a non-existent path and switching to use the related testbed spec.
hickeng
added a commit
to hickeng/vic
that referenced
this pull request
Jun 17, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it is addressing removal of a non-existent path and switching to use the related testbed spec.
hickeng
added a commit
that referenced
this pull request
Jun 19, 2018
This builds on #8047 and #8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation.
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
1. correct link construction for download of log bundles 2. correct custom test bed specified case in nimbus utils 3. clean generated log file name The spec arg has been moved to the end to reduce the changes necessary in calls to the Nimbus Deploy Testbed keyword that do not specify a custom testbed file. (cherry picked from commit 0f68789)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
1. correct link construction for download of log bundles 2. correct custom test bed specified case in nimbus utils 3. clean generated log file name The spec arg has been moved to the end to reduce the changes necessary in calls to the Nimbus Deploy Testbed keyword that do not specify a custom testbed file. (cherry picked from commit 0f68789)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
1. correct link construction for download of log bundles 2. correct custom test bed specified case in nimbus utils 3. clean generated log file name The spec arg has been moved to the end to reduce the changes necessary in calls to the Nimbus Deploy Testbed keyword that do not specify a custom testbed file. (cherry picked from commit 0f68789)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This builds on #8047 and #8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed in build https://vic-jenkins.eng.vmware.com/job/vic-integration-base/44/console