Additional fixes to integration tests#8069
Merged
hickeng merged 3 commits intovmware:masterfrom Jun 19, 2018
Merged
Conversation
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it is addressing removal of a non-existent path and switching to use the related testbed spec.
hickeng
force-pushed
the
8067
branch
2 times, most recently
from
57fff05 to
474fcbc
Compare
zjs
reviewed
Jun 18, 2018
tests/resources/Nimbus-Util.robot
Outdated
| # Simple wrapper to Wait Until Keyword Succeeds that allows callers to: | ||
| # * use default retry count and delay | ||
| # * specify specific retry counts and delays | ||
| # * robot framework executor to override both the above via the following environment variables: |
Member
There was a problem hiding this comment.
nit: This documentation reads a bit awkwardly. ("Simple wrapper to Wait Until Keyword Succeeds that allows callers to ... robot framework executor to override ...")
tests/resources/Nimbus-Util.robot
Outdated
| ${useAttempts}= Get Environment Variable NIMBUS_RETRY_ATTEMPTS ${attempts} | ||
| ${useDelay}= Get Environment Variable NIMBUS_RETRY_DELAY ${delay} | ||
|
|
||
| Wait Until Keyword Succeeds ${useAttempts} ${useDelay} ${keyword} @{varargs} No newline at end of file |
Member
There was a problem hiding this comment.
nit: missing newline at end of file
| @@ -1,3 +1,5 @@ | |||
| require ‘testframeworks/testng/testng’ | |||
Member
There was a problem hiding this comment.
Stupid question: is this the correct type of quotation mark for this context?
Contributor
Author
There was a problem hiding this comment.
I've no idea - I was given it by someone from the channel. I've dropped this file entirely in favour of a simpler construction.
hickeng
force-pushed
the
8067
branch
4 times, most recently
from
465755b to
961f1b5
Compare
This uses a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disabled the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation.
zjs
approved these changes
Jun 19, 2018
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 19, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Jul 27, 2018
This builds on vmware#8047 and vmware#8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
zjs
pushed a commit
that referenced
this pull request
Jul 27, 2018
This builds on #8047 and #8063 to address some outstanding issues left by that work. In the case of the hetrogeneous and NFS tests, it is test updates necessitated by the prior Nimbus-Util.robot updates. In the case of the VSAN tests it switches to using a testbed descriptor based off the vic-simple-cluster spec instead of what appeared to be a library spec, testng/testbeds/vsan.rb. This disables the complex vSAN testsuite at this time as I could not infer what the complex case was testing, and it is not in the test doc. It's possible that it's testing multiple vSAN datastores and our ability to use either but that's pure speculation. (cherry picked from commit d533414)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #8047 and #8063 to address some outstanding issues left by
that work. In the case of the hetrogeneous and NFS tests, it is test
updates necessitated by the prior Nimbus-Util.robot updates.
In the case of the VSAN tests it is addressing removal of a non-existent
path and switching to use the related testbed spec.
Towards #8067