chore[ci]: add windows test to CI #5439

joseph-isaacs · 2025-11-21T11:59:53Z

No description provided.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

0ax1

well, lgtm if ci is happy

codspeed-hq · 2025-11-21T12:07:55Z

CodSpeed Performance Report

Merging #5439 will degrade performances by 21.53%

_{Comparing ji/win-ci (789786b) with develop (68895ac)}

Summary

⚡ 8 improvements
❌ 5 regressions
✅ 1509 untouched
⏩ 7 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`batch[65536]`	505.3 µs	447.5 µs	+12.91%
⚡	`batch[73728]`	568.2 µs	484.3 µs	+17.33%
⚡	`in_place_batch[100352]`	381.1 µs	318.3 µs	+19.74%
⚡	`in_place_batch[16384]`	63.5 µs	53.3 µs	+19.21%
❌	`in_place_batch[73728]`	234.2 µs	280.4 µs	-16.47%
❌	`in_place_batch[8192]`	26.6 µs	33.9 µs	-21.53%
⚡	`in_place_pipeline[262144]`	398.2 µs	331 µs	+20.3%
❌	`in_place_pipeline[73728]`	95.5 µs	114.5 µs	-16.56%
❌	`pipeline[16384]`	27.7 µs	32.1 µs	-13.46%
⚡	`pipeline[262144]`	402.4 µs	335.2 µs	+20.03%
⚡	`pipeline[86016]`	136.9 µs	114.9 µs	+19.14%
❌	`pipeline_extra_copy[100352]`	132.8 µs	158.6 µs	-16.27%
⚡	`pipeline_extra_copy[65536]`	106.1 µs	88.4 µs	+20.02%

7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

- Add rust-test-other matrix job with Windows x64 and Linux ARM64 runners - Use runs-on service for both platforms (m7i for Windows, m7g for ARM) - Fix Mold linker installation to be Linux-only (prevents PowerShell error on Windows) - Enable S3 cache for Linux ARM64 runner 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

codecov · 2025-11-21T12:21:07Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (fd5a013) to head (789786b).
⚠️ Report is 5 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The arduino/setup-protoc action requires PowerShell to be in the PATH on Windows. Add it explicitly for Windows runners. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

The arduino/setup-protoc action has an issue with Expand-Archive on Windows runners. Use Chocolatey instead to install protoc on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

The windows22-base-x64 image doesn't include MSVC Build Tools which are required for compiling Rust with the msvc toolchain. Add them explicitly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

The windows22-base-x64 image doesn't have Visual Studio or vswhere installed. Switch to windows22-full-x64 which includes Visual Studio for MSVC builds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

bench-vortex has dependencies that are problematic on Windows (protoc). Exclude it from the test run and simplify protoc installation back to the standard approach. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

The windows22-full-x64 image doesn't include Visual Studio by default. Install visualstudio2022buildtools with VCTools workload via Chocolatey. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

protoc installation requires PowerShell which isn't properly configured on Windows runners. Skip it entirely for Windows since we already exclude bench-vortex which needs it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

vortex-python requires Python via pyo3 which isn't properly configured on Windows runners. Exclude it from Windows tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Use actions/setup-python to ensure Python is properly configured in PATH for pyo3-build-config. Revert vortex-python exclusion since Python will now be available. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Fix yamllint error by using double quotes instead of single quotes for python-version string value. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Add platform-specific imports for Read and Seek traits on non-Unix platforms (Windows) and fix seek call to use SeekFrom::Start. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

This reverts commit 63b759f. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

This reverts commit c83ec8a.

Reverts #5449 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

This reverts commit 63b759f. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

Reverts #5449 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

chore[ci]: add window test to CI

641a1ee

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

joseph-isaacs added the chore Release label indicating a trivial change label Nov 21, 2025

0ax1 self-requested a review November 21, 2025 12:04

0ax1 changed the title ~~chore[ci]: add window test to CI~~ chore[ci]: add windows test to CI Nov 21, 2025

0ax1 approved these changes Nov 21, 2025

View reviewed changes

joseph-isaacs force-pushed the ji/win-ci branch from 1cdae18 to ac60bb3 Compare November 21, 2025 12:09

joseph-isaacs and others added 13 commits November 21, 2025 12:26

fix

2cb363b

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

fix

789786b

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

joseph-isaacs enabled auto-merge (squash) November 21, 2025 16:28

joseph-isaacs merged commit 63b759f into develop Nov 21, 2025
44 of 46 checks passed

joseph-isaacs deleted the ji/win-ci branch November 21, 2025 16:38

joseph-isaacs mentioned this pull request Nov 21, 2025

FFI still does not build on windows #5437

Closed

0ax1 added a commit that referenced this pull request Nov 21, 2025

Revert "chore[ci]: add windows test to CI (#5439)"

b73edec

This reverts commit 63b759f. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

0ax1 added a commit that referenced this pull request Nov 21, 2025

Revert "chore[ci]: add windows test to CI (#5439)" (#5449)

c83ec8a

This reverts commit 63b759f. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

joseph-isaacs added a commit that referenced this pull request Nov 24, 2025

Revert "Revert "chore[ci]: add windows test to CI (#5439)" (#5449)"

138f721

This reverts commit c83ec8a.

joseph-isaacs added a commit that referenced this pull request Nov 24, 2025

Revert "Revert "chore[ci]: add windows test to CI (#5439)"" (#5486)

3572526

Reverts #5449 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

a10y pushed a commit that referenced this pull request Nov 25, 2025

chore[ci]: add windows test to CI (#5439)

4643c88

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

a10y pushed a commit that referenced this pull request Nov 25, 2025

Revert "chore[ci]: add windows test to CI (#5439)" (#5449)

23a88d4

This reverts commit 63b759f. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>

a10y pushed a commit that referenced this pull request Nov 25, 2025

Revert "Revert "chore[ci]: add windows test to CI (#5439)"" (#5486)

6bc568a

Reverts #5449 --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore[ci]: add windows test to CI #5439

chore[ci]: add windows test to CI #5439

Uh oh!

joseph-isaacs commented Nov 21, 2025

Uh oh!

0ax1 left a comment

Uh oh!

codspeed-hq bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore[ci]: add windows test to CI #5439

chore[ci]: add windows test to CI #5439

Uh oh!

Conversation

joseph-isaacs commented Nov 21, 2025

Uh oh!

0ax1 left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #5439 will degrade performances by 21.53%

Summary

Benchmarks breakdown

Footnotes

Uh oh!

codecov bot commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Nov 21, 2025 •

edited

Loading

codecov bot commented Nov 21, 2025 •

edited

Loading