Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Nov 21, 2025

This reverts commit 63b759f.

This reverts commit 63b759f.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #5449 will degrade performances by 19.41%

Comparing ad/revert-win (b73edec) with develop (95972bc)

Summary

⚡ 8 improvements
❌ 5 regressions
✅ 1509 untouched
⏩ 14 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
batch[100352] 747.1 µs 658.4 µs +13.46%
in_place_batch[1024] 4.6 µs 5.6 µs -17.32%
in_place_batch[16384] 67.7 µs 53.3 µs +27.09%
in_place_batch[65536] 208.4 µs 249.5 µs -16.47%
in_place_pipeline[100352] 154.5 µs 128.9 µs +19.92%
in_place_pipeline[1024] 4 µs 5 µs -19.41%
in_place_pipeline[73728] 95.5 µs 114.5 µs -16.56%
pipeline[65536] 106.1 µs 89.3 µs +18.78%
pipeline[8192] 18.7 µs 16.6 µs +12.44%
pipeline_extra_copy[100352] 132.8 µs 158.7 µs -16.3%
pipeline_extra_copy[16384] 32 µs 27.9 µs +14.85%
pipeline_extra_copy[73728] 118.4 µs 99.6 µs +18.88%
verify_all_methods[16384] 37.2 ms 21.8 ms +70.23%

Footnotes

  1. 14 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 enabled auto-merge (squash) November 21, 2025 17:42
@0ax1 0ax1 merged commit c83ec8a into develop Nov 21, 2025
44 of 46 checks passed
@0ax1 0ax1 deleted the ad/revert-win branch November 21, 2025 17:47
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.00%. Comparing base (95972bc) to head (b73edec).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joseph-isaacs added a commit that referenced this pull request Nov 24, 2025
joseph-isaacs added a commit that referenced this pull request Nov 24, 2025
Reverts #5449

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
a10y pushed a commit that referenced this pull request Nov 25, 2025
This reverts commit 63b759f.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
a10y pushed a commit that referenced this pull request Nov 25, 2025
Reverts #5449

---------

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants