moved content about trace-id into informative section as a first step…#351
Merged
SergeyKanzhelev merged 1 commit intomasterfrom Nov 5, 2019
Merged
Conversation
… of addressing larger feedback on operating 64bit systems
tylerbenson
reviewed
Nov 5, 2019
plehegar
approved these changes
Nov 5, 2019
AloisReitbauer
approved these changes
Nov 5, 2019
yurishkuro
reviewed
Nov 5, 2019
| If the `trace-id` value is invalid (for example if it contains non-allowed characters or all zeros), vendors MUST ignore the `traceparent`. | ||
|
|
||
| See [considerations for trace-id field | ||
| generation](#considerations-for-trace-id-field-generation) for recommendations |
Member
There was a problem hiding this comment.
should the link point to spec/60-trace-id-format.md ?
Member
Author
There was a problem hiding this comment.
it results in a single document... This link definitely works, not sure if it will work when we specify the markdown file name. I will check and fix all links like this if ReSpec is smart enough
yurishkuro
approved these changes
Nov 5, 2019
Member
Author
|
We discussed during the meeting today that this is not normative change for the specification. There were no concerns: Attendees |
SergeyKanzhelev
deleted the
sergkanz/moveQuestionableContentInInformativeSection
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… of addressing larger feedback on operating 64bit systems
As a first step fixing #349 the entire note about the behavior of
trace-idwas moved to informative section. The reason for this move is to enable us writing recommendation freely even if they break formal requirement of propagating entiretrace-id. This will enable us to explain better how 64bit systems should operate for better inter-oprability avoiding the demand to re-start the entiretrace-idevery time.💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Nov 3, 2019, 6:33 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.