Skip to content

Fix the section on 64bit systems#356

Merged
SergeyKanzhelev merged 13 commits intomasterfrom
sergkanz/fix64bitsystems
Nov 11, 2019
Merged

Fix the section on 64bit systems#356
SergeyKanzhelev merged 13 commits intomasterfrom
sergkanz/fix64bitsystems

Conversation

@SergeyKanzhelev
Copy link
Copy Markdown
Member

@SergeyKanzhelev SergeyKanzhelev commented Nov 6, 2019 •
edited
Loading

Fixes #349
Fixes #337

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Nov 7, 2019
Closed
yurishkuro
yurishkuro reviewed Nov 7, 2019
View reviewed changes
SergeyKanzhelev and others added 6 commits November 6, 2019 21:00
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
92191cb 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
eefc265 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
b244f70 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
3e7f884 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
aa4454b 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@SergeyKanzhelev @yurishkuro
Update spec/60-trace-id-format.md
459ffb9 
Co-Authored-By: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@tedsuo
Copy link
Copy Markdown

tedsuo commented Nov 7, 2019

Thanks @SergeyKanzhelev. One question: there was a suggestion to move this information to a "non-normative" section. Is that where this is now? Sorry for my ignorance, but I assumed the file name would be changing.

@SergeyKanzhelev
Copy link
Copy Markdown
Member Author

SergeyKanzhelev commented Nov 7, 2019

@tedsuo move to the non-normative section was already done: #351

yurishkuro
yurishkuro reviewed Nov 7, 2019
View reviewed changes
yurishkuro
yurishkuro reviewed Nov 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two suggestions to make it clear who is responsible for conversions

@justinfoote
Copy link
Copy Markdown
Member

justinfoote commented Nov 7, 2019

@yurishkuro Since there is such disagreement about which system should be required to upgrade or downgrade trace ids, perhaps it's better not to mention the system in this spec. I like the existing passive wording of When converting a....

justinfoote
justinfoote reviewed Nov 7, 2019
View reviewed changes
@SergeyKanzhelev
Copy link
Copy Markdown
Member Author

SergeyKanzhelev commented Nov 7, 2019

Hi @bogdandrutu @adriancole @tylerbenson @jcchavezs @nicmunroe @reyang @danielkhan . There are no surprises in this PR. I believe it is reflecting overall agreement on how interoperability must work. If you have some time - please review.

Thank you!

reyang
reyang reviewed Nov 7, 2019
View reviewed changes
@yurishkuro yurishkuro changed the title fix the section on 64bit systems Fix the section on 64bit systems Nov 8, 2019
@SergeyKanzhelev
Copy link
Copy Markdown
Member Author

SergeyKanzhelev commented Nov 11, 2019

Thank you everybody for reviews!

@SergeyKanzhelev SergeyKanzhelev merged commit 19a186f into master Nov 11, 2019
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/fix64bitsystems branch November 11, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

+6 more reviewers

@tedsuo tedsuo tedsuo left review comments

@tylerbenson tylerbenson tylerbenson approved these changes

@mtwo mtwo mtwo approved these changes

@justinfoote justinfoote justinfoote approved these changes

@nicmunroe nicmunroe nicmunroe approved these changes

@reyang reyang reyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inter-operability of tracing systems operating with shorter trace-id Revert advice against backfilling of zeros

8 participants

@SergeyKanzhelev @tedsuo @justinfoote @tylerbenson @mtwo @yurishkuro @nicmunroe @reyang