Create new queued prompts list UI by harryalbert · Pull Request #11439 · warpdotdev/warp

harryalbert · 2026-05-20T20:53:17Z

Description

This PR adds a new queued prompt panel, which allows for multiple queued prompts at a time, queued prompt editing, queued prompt re-arranging, and allows you to collapse your queued prompts when you don't want to look at them.

In this PR, I only update it so that direct prompt queueing uses this new UI, keeping cloud conversation setup using the old queued prompt UI. I think cloud conversation setup should use the new UI, but that's a separate workstream (that should maybe be feature flagged), so I think it deserves its own PR.

As is, the new UI is not feature flagged, as queued prompts as a whole are still in dogfood.

This is a pretty large PR, but I go into solid detail about the architecture and product decisions in the tech and product specs.

Implements APP-4563

Testing

I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/2689f5f8e12d4acabd14e6c3fa70c73e

Agent Mode

Warp Agent Mode - This PR was created via Warp's AI Agent Mode

harryalbert · 2026-05-20T20:53:32Z

Use new queued prompt panel for /compact-and and /fork-and-compact #11575
Use new queued prompt UI for cloud mode #11547
Create new queued prompts list UI #11439 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

oz-for-oss · 2026-05-20T20:56:53Z

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR adds a terminal-owned queued prompt model and a new queued-prompts panel, then routes /queue and auto-queue submissions through it while leaving Cloud Mode and compact placeholders on the legacy pending-user-query UI.

Concerns

Two active-AI-block lookup paths no longer skip legacy pending-user-query rich content, so Cloud Mode/compact placeholders can hide the real active AI block from downstream logic.
The new test modules call QueuedQuery::into_text(), but the PR only defines text(), so the test build will fail.

Verdict

Found: 0 critical, 4 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

zachbai · 2026-05-22T18:48:35Z

+29. Rows reflow as the dragged item crosses the midpoint of a neighboring row, making the tentative new order visible before drop.
+30. Legacy pending-user-query placeholders for Cloud Mode, `/compact-and`, and `/fork-and-compact` are outside this panel, so they do not participate in drag-to-reorder.
+### Sequential firing
+31. When the active conversation reaches `FinishReason::Complete`, the first prompt in the queue is removed and submitted as the next user query in the same conversation, routed through the normal submission path so slash, skill, and session-sharing paths are handled correctly.


what happens if this is emitted while there's an active drag-to-reorder?

If a different row is removed, the drag just continues and we re-compute the dragged item's position, so it's robust to changes there.

If the row that you're dragging is removed, and the row is currently in the first position, then the item would just disappear and be sent.

if you take row 1, drag it below row 2, and then the prompt auto-fires while you're dragging, row 2 will be correctly auto-fired even if you haven't released yet.

I can clarify the spec w/ all of these variants

zachbai · 2026-05-22T18:52:13Z

+32. While that newly-fired prompt is mid-exchange, the rest of the queue stays intact, the panel updates the count to `<N-1> queued`, and additional prompts can still be queued at the tail.
+33. The cycle continues until either the queue is empty or one of the abort conditions in (34) fires.
+### Cancellation and error handling
+34. When the active conversation finishes for any non-`Complete` reason — `Error`, `Cancelled`, `CancelledDuringRequestedCommandExecution` — auto-fire pauses immediately. The queue is not flushed.


we should see how this feels in dev but I'm pretty sure that claude code auto-sends the next queued propmt on cancel

hmm, that's interesting. I kind of think we should follow claude semantics given it's what people will expect, so I might just change this to send on cancel

zachbai · 2026-05-22T19:03:51Z

+`TerminalView::new` constructs one `QueuedQueryModel` per terminal view and hands that model to the input and queued-prompts panel (`app/src/terminal/view.rs (3707-4370)`). The model is terminal-owned because the panel and input are terminal-owned UI, but its rows are keyed by `AIConversationId` so switching conversations hides or reveals the correct queue without folding queue data into `TerminalView` itself. `BlocklistAIHistoryModel` remains responsible for conversation history only; queue cleanup reacts to its terminal-scoped events from `TerminalView`.
+
+`QueuedQueryModel` is the source of truth for regular queued prompts (`app/src/ai/blocklist/queued_query.rs (90-365)`):
+- `queues: HashMap<AIConversationId, Vec<QueuedQuery>>` stores FIFO queue contents per conversation.


do we actually need to store multiple queues per terminal view - in theory this lets you preserve a queue of messages across agent view enter/exit boundaries in the same terminal view yea?

But the queue is still terminal view scoped, so if you queued 3 messages in one terminal pane while the conversation was paused, then restored in another pane, it wouldn't have the queue?

Maybe this model shoudl be a singleton? Or queuing should be explicitly considered transient state in a given agent view?

Not blocking but just calling out

Good call, I was just reviewing this PR and noticed that this map is unnecessary. Refactoring now so that it's just one list per view.

I think a singleton would maybe also make sense if we wanted the queue to be persistent across exiting and re-entering an agent view? But I think we should keep it simple for now and just consider queued prompts transient state in an open agent view

cla-bot Bot added the cla-signed label May 20, 2026

harryalbert marked this pull request as ready for review May 20, 2026 20:56

harryalbert requested a review from zachbai May 20, 2026 20:56

harryalbert changed the title ~~update queued prompt UI~~ Create new queued prompts list May 20, 2026

harryalbert changed the title ~~Create new queued prompts list~~ Create new queued prompts list UI May 20, 2026

harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 5428969 to 332c4c9 Compare May 20, 2026 20:58

oz-for-oss Bot reviewed May 20, 2026

View reviewed changes

Comment thread app/src/terminal/view.rs

Comment thread app/src/terminal/view.rs

Comment thread app/src/ai/blocklist/queued_query_tests.rs Outdated

Comment thread app/src/terminal/view/queued_prompts_test.rs Outdated

harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 332c4c9 to f31a7b6 Compare May 22, 2026 16:57

harryalbert mentioned this pull request May 22, 2026

Use new queued prompt UI for cloud mode #11547

Open

2 tasks

zachbai approved these changes May 22, 2026

View reviewed changes

harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch 2 times, most recently from 2b9f553 to 7c923bb Compare May 22, 2026 21:23

update queued prompts to use new UI

0d27d8f

harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 7c923bb to 4a0343f Compare May 22, 2026 21:30

simpilfy events and ownership

e17fec3

harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 4a0343f to e17fec3 Compare May 22, 2026 21:37

harryalbert mentioned this pull request May 22, 2026

Use new queued prompt panel for /compact-and and /fork-and-compact #11575

Draft

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create new queued prompts list UI#11439

Create new queued prompts list UI#11439
harryalbert wants to merge 2 commits into
masterfrom
harry/app-4532-update-queued-prompts-to-use-new-ui

harryalbert commented May 20, 2026 •

edited

Loading

Uh oh!

harryalbert commented May 20, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot commented May 20, 2026 •

edited

Loading

Uh oh!

oz-for-oss Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zachbai May 22, 2026

Uh oh!

harryalbert May 22, 2026

Uh oh!

zachbai May 22, 2026

Uh oh!

harryalbert May 22, 2026

Uh oh!

zachbai May 22, 2026

Uh oh!

harryalbert May 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

harryalbert commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Screenshots / Videos

Agent Mode

Uh oh!

harryalbert commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zachbai May 22, 2026

Choose a reason for hiding this comment

Uh oh!

harryalbert May 22, 2026

Choose a reason for hiding this comment

Uh oh!

zachbai May 22, 2026

Choose a reason for hiding this comment

Uh oh!

harryalbert May 22, 2026

Choose a reason for hiding this comment

Uh oh!

zachbai May 22, 2026

Choose a reason for hiding this comment

Uh oh!

harryalbert May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

harryalbert commented May 20, 2026 •

edited

Loading

harryalbert commented May 20, 2026 •

edited

Loading

oz-for-oss Bot commented May 20, 2026 •

edited

Loading

harryalbert May 22, 2026 •

edited

Loading