Skip to content

Use new queued prompt UI for cloud mode#11547

Open
harryalbert wants to merge 6 commits into
harry/app-4532-update-queued-prompts-to-use-new-uifrom
harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt
Open

Use new queued prompt UI for cloud mode#11547
harryalbert wants to merge 6 commits into
harry/app-4532-update-queued-prompts-to-use-new-uifrom
harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented May 22, 2026 •
edited
Loading

Description

now that we have the new queued prompt UI in place, we can use it for cloud mode v2 setup (behind a feature flag for now).

This was the original goal with Peter's design for this panel, and it's a big level up because it allows folks to send prompts (albeit delayed prompts) while cloud mode is still starting up.

Fixes APP-4452

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/4996efd3da6041ce8cb338acfd318ade

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label May 22, 2026
@harryalbert harryalbert mentioned this pull request May 22, 2026
Open
2 tasks
@harryalbert Graphite App
Copy link
Copy Markdown
Contributor Author

harryalbert commented May 22, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@harryalbert harryalbert changed the title add product and tech specs Use new queued prompt UI for cloud mode setup May 22, 2026
@harryalbert harryalbert changed the title Use new queued prompt UI for cloud mode setup Use new queued prompt UI for cloud mode May 22, 2026
@harryalbert harryalbert marked this pull request as ready for review May 22, 2026 17:01
@harryalbert harryalbert requested a review from zachbai May 22, 2026 17:01
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 22, 2026 •
edited
Loading

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss[bot]
oz-for-oss Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR routes Cloud Mode setup and follow-up prompts through the queued-prompts panel behind QueuedPromptsV2, including locked initial rows, cloud-status-based draining, and cloud follow-up submission routing. The attached Loom satisfies the repository requirement for visual evidence on this UI-facing change.

Concerns

  • Cloud setup queueing currently captures shell-mode input because the new helper does not check that AI input is active before clearing and appending the buffer.
  • Drained queued prompts can be removed and then dropped when QueuedPromptsV2 is enabled without HandoffCloudCloud, because the queued cloud follow-up path omits the flag gate used by manual follow-up submission.

Verdict

Found: 0 critical, 2 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread app/src/terminal/input.rs
.as_ref(ctx)
.is_ready_for_cloud_followup_prompt()
});
if is_ready_for_cloud_followup {
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This branch can drop queued cloud prompts when HandoffCloudCloud is disabled. QueuedPromptsV2 only enables queue_slash_command, so a runtime with V2 on and HandoffCloudCloud off will pop the row, emit SubmitCloudFollowup, and then submit_cloud_followup returns without sending it. Mirror the user-initiated FeatureFlag::HandoffCloudCloud.is_enabled() gate before selecting this path.

Copy link
Copy Markdown
Contributor Author

@harryalbert harryalbert May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're ever gonna turn this feature flag off, so I'm not worried about this

Comment thread app/src/terminal/input.rs
return false;
}

let should_queue = self
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] This captures shell-mode input during cloud setup because the helper never checks that AI input is active. The existing in-progress queue path gates on ai_input_model.is_ai_input_enabled(), but this path runs before shell execution, so ls can be appended as an AutoQueueToggle prompt instead of executing. Add the same AI-input guard before queueing.

Copy link
Copy Markdown
Contributor Author

@harryalbert harryalbert May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fine — there's no way to run a terminal command during setup anyways, so I'm not worried about this

@harryalbert harryalbert force-pushed the harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt branch 2 times, most recently from d5e202c to 935dd4f Compare May 22, 2026 19:22
@harryalbert harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 3650da7 to 933f22a Compare May 22, 2026 19:22
@harryalbert harryalbert force-pushed the harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt branch from 935dd4f to 5f4143a Compare May 22, 2026 19:47
@harryalbert harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 2b9f553 to 7c923bb Compare May 22, 2026 21:23
@harryalbert harryalbert force-pushed the harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt branch 2 times, most recently from 2fc79ee to 8be80c9 Compare May 22, 2026 21:30
@harryalbert harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 7c923bb to 4a0343f Compare May 22, 2026 21:30
@harryalbert harryalbert force-pushed the harry/app-4532-update-queued-prompts-to-use-new-ui branch from 4a0343f to e17fec3 Compare May 22, 2026 21:37
@harryalbert harryalbert force-pushed the harry/app-4562-get-prompt-queuing-working-for-cloud-runs-and-enable-prompt branch from 8be80c9 to fcaea51 Compare May 22, 2026 21:37
@harryalbert harryalbert mentioned this pull request May 22, 2026
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oz-for-oss oz-for-oss[bot] oz-for-oss[bot] left review comments

@zachbai zachbai Awaiting requested review from zachbai

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@harryalbert