Fix CMake Variable Naming #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
GAUXC_ENABLE_XYZvariables did all the heavy lifting for feature detection and control. Per @loriab's comments and subsequent issue (#102),these variables sound suspiciously editable, so probably best to not rely on that naming scheme.This PR separates out
GAUXC_ENABLE_XYZto trigger detection of featureXYZand setsGAUXC_HAS_XYZif the feature has been detected and enabled throughout the stack.Major Change: Do not use
GAUXC_ENABLE_XYZdownstream to check feature behaviour, only use these variables to enable features via FetchContent and useGAUXC_HAS_XYZto check if the feature enable happened. The latter should also be used for source-level feature detection (e.g.GAUXC_HAS_DEVICEcan be used to check if GauXC has device bindings)Closes #102
TODO: Check downstream integrations: