-
Notifications
You must be signed in to change notification settings - Fork 28
Add GPU Capability as exported property #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPU Capability as exported property #101
Conversation
wavefunction91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally in favor of this, but it should probably just encompass all the propoerties we'll need to export. Essentially all the options. Also, per discussion with @loriab, I got to thinking that we may want to export some other things that (aren't currently) configurable, but might be in the future - things like GAUXC_CPU_XC_MAX_AM GAUXC_GPU_SNLINK_MAX_AM, etc
Duly noted! I expanded the list of configurable properties. I think the list now includes all of the GauXC-specific configurable options, which I gathered from a combination of the I'm admittedly not sure of what "potentially configurable" options might want to be added to the list, but I'll be happy to add them. I at least added the ones you mentioned here, setting the default to what I saw was the default |
|
EDIT: otoh, if these are the variables already set in cmake (either main build or gauxc-config.cmake), it's probably simpler to leave them as current name rather than switching around just b/c they're now on the target. |
Yeah, these are all set in CMake already (barring the "non-configurable" options @wavefunction91 brought up), so I'll probably just leave them as the current name. |
wavefunction91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is in good shape. I'll make another PR to cleanup per @loriab's comments re variable naming (actually, if you or she could make an issue to that affect, that would be great). Othertiwse, LGTM after changes - I'll approve CI once fixed
e5addbd to
76e4f53
Compare
Thanks much! I believe my recent commit should address all of the suggestions that you raised previously. Once your PR for variable renaming is set up, I'll adjust the naming scheme here to match. |
|
@davpoolechem can you update this PR to include #103 so we can hit the ground running once it gets checked in? |
76e4f53 to
196996a
Compare
All right, should be done now! |
|
CI is failing because the |
|
Merging #114 should fix the configure error (it does locally at least) |
196996a to
3150481
Compare
|
@davpoolechem Per offline discussion, lets punt on the CMake UTs with these variables. I'll add an issue to track |
@loriab and I were talking about the Psi4/GauXC build system yesterday, and we both agreed that something along the lines of this PR would be quite useful for the Psi4/GauXC interface build system. Specifically, it would be nice for GauXC to have a property/component which would return whether the given instance of GauXC was built with GPU support or not, which is what this PR does.
Let me know if anything could be done in a more kosher fashion, of course!