Clean up the Gauss-Legendre quadrature code #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susilehtola
force-pushed
the
gauleg_cleanup
branch
from
57d8b0f to
7835da7
Compare
wavefunction91
requested changes
Jul 9, 2023
Owner
wavefunction91
left a comment
wavefunction91
left a comment
There was a problem hiding this comment.
Agree on removing the bounds and making them external, I had been meaning to remove these from the GC quads as well since those parameters are unused.
We do need to have access to the "natural" bounds of the quadrature though, will add an issue to track.
susilehtola
force-pushed
the
gauleg_cleanup
branch
3 times, most recently
from
4c34e90 to
d754d04
Compare
…for odd numbers of points.
susilehtola
force-pushed
the
gauleg_cleanup
branch
from
d754d04 to
a65c69d
Compare
wavefunction91
approved these changes
Jul 9, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups to Gauss-Legendre quadrature. Now the code also works for odd numbers of points. I also checked that the nodes are returned in increasing order.
In my opinion, transformations should not be hardcoded in the individual quadrature rule; instead, the transformation should be applied later.