Expose the HTTP server from the server struct.#118
Merged
bboreham merged 3 commits intoweaveworks:masterfrom Aug 24, 2018
Merged
Expose the HTTP server from the server struct.#118bboreham merged 3 commits intoweaveworks:masterfrom
bboreham merged 3 commits intoweaveworks:masterfrom
Conversation
This allows users to inject HTTP requests and have the logged, instrumented and traced correctly. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
bboreham
reviewed
Aug 23, 2018
| GRPC *grpc.Server | ||
| Log logging.Interface | ||
| HTTP *mux.Router | ||
| HTTPServer *http.Server |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Collaborator
|
note CI tests failed |
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
tomwilkie
force-pushed
the
expose-http-server
branch
from
4e46207 to
19e9115
Compare
Contributor
Author
|
I think its flake #120 |
…eturn an error before Run starts listening on errChan. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
bboreham
approved these changes
Aug 24, 2018
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to inject HTTP requests and have the logged, instrumented and traced correctly.
See cortexproject/cortex#949
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com