Skip to content

Add middleware to detect jaeger trace context over HTTP#3325

Merged
bboreham merged 2 commits intomasterfrom
trace-context-detect
Aug 28, 2018
Merged

Add middleware to detect jaeger trace context over HTTP#3325
bboreham merged 2 commits intomasterfrom
trace-context-detect

Conversation

@leth
Copy link
Contributor

@leth leth commented Aug 23, 2018

Previously scope would not honor http headers requesting that a request be traced.

Updates weaveworks/common to d442d08d89b51712ca61de3f7c14e2e218a739d7

@leth leth requested a review from bboreham August 23, 2018 12:04
Copy link
Contributor

@dlespiau dlespiau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bboreham
Copy link
Collaborator

Why wouldn't this go in weaveworks/common/middleware ?

@leth
Copy link
Contributor Author

leth commented Aug 23, 2018

Why wouldn't this go in weaveworks/common/middleware ?

I didn't think this was possible initially; I've worked out how to do it now!

Changes:
- Default diff-printer to hide details (#103) - da4c3ff
- Improve logging of http errors (#115) - f5a1710
- Update httpgrpc to match cortexproject/cortex#910 (#117) - 80ff076
- Expose the HTTP server from the server struct. (#118) - 1a7a6b3
- Add HTTP tracing middleware (#119) - d442d08
@leth leth force-pushed the trace-context-detect branch from c452f31 to e8eb7af Compare August 28, 2018 10:40
@leth leth force-pushed the trace-context-detect branch from e8eb7af to 67b887c Compare August 28, 2018 12:32
@bboreham bboreham merged commit 4e08ea0 into master Aug 28, 2018
@leth leth deleted the trace-context-detect branch August 28, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants