Allow config of TLS cipher suites and min version#256
Merged
Conversation
This was referenced Sep 1, 2022
aknuds1
reviewed
Sep 7, 2022
Contributor
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
Wondering if the parameters shouldn't also be applied for gRPC.
aknuds1
reviewed
Sep 8, 2022
Contributor
aknuds1
left a comment
aknuds1
left a comment
There was a problem hiding this comment.
LGTM, except you should probably drop the replace now that the PR is merged.
aknuds1
approved these changes
Sep 9, 2022
Collaborator
Author
|
Trying to fix the build at #258 |
Add a single parameter for each, not split across HTTP and gRPC. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This brings in a few other dependency updates. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
tls-more-config
branch
from
6cac2df to
2a2a019
Compare
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a single parameter for each, not split across HTTP and gRPC.
Requires change upstream - prometheus/exporter-toolkit#110. This PR is temporarily using a
replacedirective to use that code.Downstream projects rely on CLI parameters to generate docstrings, so we add
--server.tls-cipher-suitesand--server.tls-min-version. Both CLI and yaml require comma-separated lists of cipher suites, which is different to the yaml array format supported byprometheus/exporter-toolkit.The names accepted are from Go, listed here: https://pkg.go.dev/crypto/tls#pkg-constants
Fixes #248 (partial, but I haven't seen a justification to do the curves, max version, etc).