Update CI build to Go 1.17; drop BUILD_IN_CONTAINER#258
Merged
stefanprodan merged 4 commits intomasterfrom Sep 12, 2022
Merged
Conversation
There is no weaveworks/build image newer than Go 1.14, and we don't really need one. For CI, switch to using CircleCI's image, and for local builds assume the user has Go installed. This commit leaves protobuf generation somewhat broken, to be fixed in the next commit. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Use a 3rd-party image `namely/protoc:1.22_1`, which generates identical output for two of the protos in this repo. The third one, httpgrpc, I have not managed to match exactly, but the result is very close. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
aknuds1
approved these changes
Sep 9, 2022
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
stefanprodan
approved these changes
Sep 12, 2022
Contributor
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @bboreham 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no
weaveworks/build-golangimage newer than Go 1.14, and we don't really need one.For CI, switch to using CircleCI's image, and for local builds assume the user has Go installed.
Also switch to
golangci-lint, although I suppressed any pre-existing issues. Can fix them in a different PR.The one thing which is tricky to set up locally is protobuf generation, which is not used in CI.
The fact that the three
.pb.gofiles in this repo were generated using two different proto commands suggests it was never done consistently.To avoid leaving protos broken, I have used a 3rd-party image
namely/protoc:1.22_1, which generates identicaloutput for two of the protos in this repo.
The third one, httpgrpc, I have not managed to match exactly, but the result is very close.
I have not updated the
.pb.gofiles however. Leave that till when someone needs an update.Also dropped a lot of boilerplate from the makefile which was not needed.