ci: Fix CI workflows to prevent script injection#4046
Merged
yiannistri merged 2 commits intomainfrom Sep 29, 2023
Merged
Conversation
yiannistri
force-pushed
the
fix-dangerous-workflows
branch
from
9921447 to
b323564
Compare
yitsushi
approved these changes
Sep 29, 2023
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Introduced an intermediate environment variable to prevent script injection in CI workflows. See https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable for more details.
Why was this change made?
To prevent script injection in CI. Also to address issues such as https://github.com/weaveworks/weave-gitops/security/code-scanning/3781
How was this change implemented?
By introducing an intermediate environment variable.
How did you validate the change?
CI
Release notes
N/A
Documentation Changes
N/A