Conversation
- var interpolation wasn't working with single quotes - also introduce change to skip versioning on PRs which makes the build much faster
AsmaaNabilBakr
pushed a commit
that referenced
this pull request
Oct 10, 2023
* Fixes staging-docs - var interpolation wasn't working with single quotes - also introduce change to skip versioning on PRs which makes the build much faster * Don't disable versioning on PRs
Merged
AsmaaNabilBakr
added a commit
that referenced
this pull request
Oct 26, 2023
* Fixes staging-docs (#4070) * Fixes staging-docs - var interpolation wasn't working with single quotes - also introduce change to skip versioning on PRs which makes the build much faster * Don't disable versioning on PRs * add notifications * Update javascript library version to 0.34.0 * Update helm chart to 4.0.32 to use gitops 0.34.0 * Update the helm reference * Update docs for release 0.34.0 * Update README to point download link to 0.34.0 * Remove test-connection.yaml * replace notiication context with props from EE * fix notifications * using AlertListErrors in Page * fix alert message padding --------- Co-authored-by: Simon <footless@gmail.com> Co-authored-by: weave-gitops-bot <weave-gitops-bot@weave.works> Co-authored-by: Lauri <lauri@weave.works>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISABLE_VERSIONING=true yarn buildto dramatically speed up builds when testing things..)What changed?
Some of the github action code, switch from single
''to double""quoted strings so we can do the var interpolationSwitch to env vars which relied on the variable expansion made in #4046
Why was this change made?
So staging docs works
How was this change implemented?
How did you validate the change?
Checked that the staging docs now works