Add notification component#4079
Merged
AsmaaNabilBakr merged 15 commits intomainfrom Oct 26, 2023
Merged
Conversation
* Fixes staging-docs - var interpolation wasn't working with single quotes - also introduce change to skip versioning on PRs which makes the build much faster * Don't disable versioning on PRs
AsmaaNabilBakr
requested review from
joshri and
jpellizzari
and removed request for
joshri
jpellizzari
reviewed
Oct 23, 2023
Contributor
jpellizzari
left a comment
jpellizzari
left a comment
There was a problem hiding this comment.
@AsmaaNabilBakr Is this related to any feature work or other issue? Also, could you add a screenshot to the PR description so we can see the changes visually?
Contributor
Author
@jpellizzari I added the issue, and there's no visual changes I just move the |
AsmaaNabilBakr
requested review from
TheGostKasper and
jpellizzari
and removed request for
TheGostKasper
jpellizzari
approved these changes
Oct 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
AlertErrorListcomponent toOSSinstead ofEEand use it inPagecomponentWhy was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes