Turn on react / react-hook eslinters to ensure consistency with EE#4182
Closed
AlinaGoaga wants to merge 15 commits intomainfrom
Closed
Turn on react / react-hook eslinters to ensure consistency with EE#4182AlinaGoaga wants to merge 15 commits intomainfrom
AlinaGoaga wants to merge 15 commits intomainfrom
Conversation
Bumps [msgpackr](https://github.com/kriszyp/msgpackr) from 1.5.5 to 1.10.1. - [Release notes](https://github.com/kriszyp/msgpackr/releases) - [Commits](https://github.com/kriszyp/msgpackr/commits/v1.10.1) --- updated-dependencies: - dependency-name: msgpackr dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…k which isnt used
…this type of object
AlinaGoaga
changed the title
…weaveworks/weave-gitops into turn-on-react-hook-eslinters
Contributor
|
The react and react-hook eslinters are now enabled after #4564 merged. I tried to incorporate the code changes in this PR, but I found it to risky to do without in-dept knowledge of the application. I am going to close this PR now, but feel free to reopen to fix some of the currently turned of linter rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3457
Prior to merging this we will need to have remove-req-use-useAsyncFn merged in EE as the removal of
useRequestStatewill break enterprise.What changed?
As agreed in triage:
Introduced
react/react-hookrules in eslint config to match EE's eslint configDeactivated: