Skip to content

ci(lint): add react and react-hook eslinters#4564

Merged
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:react-eslint
Jan 18, 2025
Merged

ci(lint): add react and react-hook eslinters#4564
erikgb merged 1 commit intoweaveworks:mainfrom
erikgb:react-eslint

Conversation

@erikgb
Copy link
Copy Markdown
Contributor

@erikgb erikgb commented Jan 18, 2025

Closes

What changed?

I tried to merge in the changes performed in #4182, but there were some massive conflicts. So I decided not to risk breaking the application and instead turned off the new recommended rules currently broken. We should try to fix this in follow-up PRs.

Why was this change made?

Increase code quality.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb changed the title ci(lint): turn on react/react-hook eslinters ci(lint): add react eslinter Jan 18, 2025
@erikgb erikgb changed the title ci(lint): add react eslinter ci(lint): add react and react-hook eslinters Jan 18, 2025
@erikgb erikgb force-pushed the react-eslint branch 3 times, most recently from 3d86d8e to a0de921 Compare January 18, 2025 19:19
@erikgb erikgb requested review from gusevda and mproffitt January 18, 2025 19:24
@erikgb erikgb marked this pull request as ready for review January 18, 2025 19:24
Copy link
Copy Markdown
Contributor

@gusevda gusevda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@erikgb erikgb enabled auto-merge (rebase) January 18, 2025 20:53
@erikgb erikgb merged commit d5996f0 into weaveworks:main Jan 18, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants