chore!: remove core server GetSessionLogs operation#4325
Merged
casibbald merged 1 commit intoweaveworks:mainfrom Dec 30, 2024
Merged
chore!: remove core server GetSessionLogs operation#4325casibbald merged 1 commit intoweaveworks:mainfrom
casibbald merged 1 commit intoweaveworks:mainfrom
Conversation
casibbald
added a commit
that referenced
this pull request
Jan 6, 2025
Reverts #4325 Reverting, now that the following [PR](johannesboyne/gofakes3#100) has made it into Goflakes3
This was referenced Jan 15, 2025
This was referenced Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
This deletes the implementation of the
GetSessionLogscore server operation - making it unimplemented in the proto gRPC API. It seems like the function is unused, and I have a feeling it got removed as part of weaveworks/weave-gitops-enterprise#3514.Why was this change made?
The main benefit of this change is removing the dependency to
github.com/johannesboyne/gofakes3- which is currently replaced with a forked version. We could try to get the required improvements from the fork into the upstream project, but that will probably require some effort like writing new tests, etc. A bonus from removing this dependency is that we will also get rid of the transitive dependency to AWS SDK v1 - which is unmaintained and reported as vulnerable by our scanners.How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes