Skip to content

Revert "chore!: remove core server GetSessionLogs operation"#4454

Merged
casibbald merged 2 commits intomainfrom
revert-4325-remove-session-logs
Jan 6, 2025
Merged

Revert "chore!: remove core server GetSessionLogs operation"#4454
casibbald merged 2 commits intomainfrom
revert-4325-remove-session-logs

Conversation

@casibbald
Copy link
Copy Markdown
Collaborator

Reverts #4325

Reverting, now that the following PR has made it into Goflakes3

erikgb
erikgb previously approved these changes Jan 6, 2025
"github.com/weaveworks/weave-gitops/pkg/logger"
"github.com/weaveworks/weave-gitops/pkg/run/constants"
"github.com/weaveworks/weave-gitops/pkg/server/auth"
//nolint:gci
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikgb Had to add linter ignore


sourcev1 "github.com/fluxcd/source-controller/api/v1"
"github.com/minio/minio-go/v7"
//nolint:gci
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikgb Had to add linter ignore

@casibbald casibbald requested a review from erikgb January 6, 2025 19:04
@casibbald casibbald merged commit f411135 into main Jan 6, 2025
@casibbald casibbald deleted the revert-4325-remove-session-logs branch January 6, 2025 19:12
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants