ci(lint): fix react/no-unknown-property eslint violations#4582
Merged
erikgb merged 1 commit intoweaveworks:mainfrom Jan 19, 2025
Merged
ci(lint): fix react/no-unknown-property eslint violations#4582erikgb merged 1 commit intoweaveworks:mainfrom
erikgb merged 1 commit intoweaveworks:mainfrom
Conversation
mproffitt
reviewed
Jan 19, 2025
|
|
||
| "react/display-name": 0, | ||
| "react/no-children-prop": 0, | ||
| "react/no-unknown-property": 0, |
Contributor
There was a problem hiding this comment.
did you mean to still remove this? Looks like you fixed the issues it related to so maybe then leave it in place?
Contributor
Author
There was a problem hiding this comment.
Yes, my intent was to remove it - since it currently turns the rule off. It is turned on by the recommended react eslint rules.
mproffitt
approved these changes
Jan 19, 2025
This was referenced Jan 26, 2025
This was referenced Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Fix and enable the react/no-unknown-property eslint rule.
Why was this change made?
Follow-up after introducing react eslint. The react/no-unknown-property rule is a recommended rule.
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes