Skip to content

ci(lint): fix react/no-unknown-property eslint violations #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikgb merged 1 commit into from
Jan 19, 2025
Merged

ci(lint): fix react/no-unknown-property eslint violations #4582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ export default tseslint.config([

"react/display-name": 0,
"react/no-children-prop": 0,
"react/no-unknown-property": 0,
Copy link
Copy Markdown
Contributor

@mproffitt mproffitt Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to still remove this? Looks like you fixed the issues it related to so maybe then leave it in place?

Copy link
Copy Markdown
Contributor Author

@erikgb erikgb Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my intent was to remove it - since it currently turns the rule off. It is turned on by the recommended react eslint rules.

"react/prop-types": 0,
"react-hooks/exhaustive-deps": 0,
"react-hooks/rules-of-hooks": 0,
Expand Down
1 change: 0 additions & 1 deletion ui/components/DagGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ function DagGraph({ className, nodes }: Props) {
height={nodeSize.height}
key={index}
transform={`translate(${d.x - nodeSize.width / 2}, ${d.y})`}
fill="white"
strokeWidth={2}
stroke={"#737373"}
overflow="visible"
Expand Down
1 change: 0 additions & 1 deletion ui/components/DirectedGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ function DirectedGraph({
height={nodeSize.height}
key={index}
transform={`translate(${d.x - nodeSize.width / 2}, ${d.y})`}
fill="white"
strokeWidth={2}
stroke={"#737373"}
overflow="visible"
Expand Down